Make methods in crypto/algorithms async #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make internal methods of megolm.js ready for asynchronous olmdevice
richvdh
force-pushed
the
rav/async_crypto/algorithms
branch
from
9c607e5
to
d821082
Compare
kegsay
reviewed
Aug 9, 2017
| const deviceInfo = {}; | ||
| mockCrypto.getStoredDevice.andReturn(deviceInfo); | ||
|
|
||
| const awaitEnsureSessions = new Promise((res, rej) => { |
There was a problem hiding this comment.
You never return this from the promise chain which is returned to the test framework, so this test isn't waiting for all the stuff inside here to run.
There was a problem hiding this comment.
Ignore me, indentation on this diff threw me.
|
LGTM |
kegsay
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.