keep track of event ID and timestamp of decrypted messages #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid false positives when detecting replay attacks. fixes: element-hq/element-web#3712 Signed-off-by: Hubert Chathi <[email protected]>
|
suggestions welcome for how to format lines 833 and 834 of src/crypto/OlmDevice.js to avoid the lint error |
richvdh
approved these changes
Oct 12, 2017
src/crypto/OlmDevice.js
Outdated
| const messageIndexKey = senderKey + "|" + sessionId + "|" + res.message_index; | ||
| if (messageIndexKey in self._inboundGroupSessionMessageIndexes) { | ||
| if (messageIndexKey in self._inboundGroupSessionMessageIndexes | ||
| && (argumentsLength <= 4 // Compatibility for older old versions. |
src/crypto/OlmDevice.js
Outdated
| // | ||
| // Keys are strings of form "<senderKey>|<session_id>|<message_index>" | ||
| // Values are true. | ||
| // Values are objects containing the event ID and timestamp. |
There was a problem hiding this comment.
could you specify the keys here?
"values are objects of the format {id: <event id>, timestamp: <ts>}"
src/crypto/OlmDevice.js
Outdated
| if (messageIndexKey in self._inboundGroupSessionMessageIndexes | ||
| && (argumentsLength <= 4 // Compatibility for older old versions. | ||
| || self._inboundGroupSessionMessageIndexes[messageIndexKey].id !== eventId | ||
| || self._inboundGroupSessionMessageIndexes[messageIndexKey].timestamp !== timestamp)) { |
Signed-off-by: Hubert Chathi <[email protected]>
|
@richvdh this PR is ready for re-review |
|
Thanks! |
uhoreg
added a commit
to uhoreg/matrix-doc
that referenced
this pull request
Oct 31, 2017
…attacks ref: matrix-org/matrix-js-sdk#554 and matrix-org/matrix-js-sdk#555 Signed-off-by: Hubert Chathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid false positives when detecting replay attacks.
fixes: element-hq/element-web#3712
Signed-off-by: Hubert Chathi [email protected]
@richvdh PTAL