Fix notifEvent computation #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously computing notifEvents at the point where we processed them but before the room they belong to was stored. This was problematic because some push conditions try to get the room and therefore failed. Since the push actions are cached, this spurious calculation also got cached. This moves the calculation out to a separate function that gets called only after the room has been stored.
richvdh
approved these changes
Oct 25, 2017
src/sync.js
Outdated
| * @param {MatrixEvent[]} [timelineEventList] A list of timeline events. Lower index | ||
| * is earlier in time. Higher index is later. | ||
| */ | ||
| SyncApi.prototype._processEventForNotifs = function(room, timelineEventList) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously computing notifEvents at the point where we
processed them but before the room they belong to was stored.
This was problematic because some push conditions try to get the
room and therefore failed. Since the push actions are cached, this
spurious calculation also got cached.
This moves the calculation out to a separate function that gets
called only after the room has been stored.