Add erase option to deactivateAccount
#649
Conversation
For erasing messages etc. after deactivation.
src/base-apis.js
Outdated
| body = { | ||
| auth: auth, | ||
| }; | ||
| MatrixBaseApis.prototype.deactivateAccount = function(auth, erase, callback) { |
There was a problem hiding this comment.
this should never need three parameters? if you want to pass erase, you should use promises instead of callbacks
src/base-apis.js
Outdated
| auth: auth, | ||
| }; | ||
| MatrixBaseApis.prototype.deactivateAccount = function(auth, erase, callback) { | ||
| if (typeof(erase) === 'function') { |
There was a problem hiding this comment.
elsewhere we have a comment along the lines of "erase used to be callback" or words to that effect
src/base-apis.js
Outdated
| callback = erase; | ||
| erase = undefined; | ||
| } | ||
| if (typeof(auth) === 'function') { |
src/base-apis.js
Outdated
| } | ||
|
|
||
| const body = {}; | ||
| if (typeof(auth) === 'object') { |
There was a problem hiding this comment.
what was wrong with if (auth) ?
src/base-apis.js
Outdated
| ); | ||
| } | ||
|
|
||
| const body = { auth, erase }; |
There was a problem hiding this comment.
actually, neither should erase... gah my brain is melting over simple changes
src/base-apis.js
Outdated
| return this._http.authedRequestWithPrefix( | ||
| callback, "POST", '/account/deactivate', undefined, body, httpApi.PREFIX_UNSTABLE, | ||
| undefined, "POST", '/account/deactivate', undefined, body, | ||
| httpApi.PREFIX_UNSTABLE, |
There was a problem hiding this comment.
can you fix this while you are here please
There was a problem hiding this comment.
I've moved it to R0, which I think is correct.
There was a problem hiding this comment.
well you could just use authedRequest and let it use the default prefix (which is indeed R0) but this is better at least
For erasing messages etc. after deactivation.