fix auth header and filename=undefined #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
requested changes
Jun 18, 2018
src/base-apis.js
Outdated
| @@ -1071,6 +1071,10 @@ MatrixBaseApis.prototype.searchUserDirectory = function(opts) { | |||
| * @param {string=} opts.name Name to give the file on the server. Defaults | |||
| * to <tt>file.name</tt>. | |||
| * | |||
| * @param {boolean=} opts.omitFilename if true will not send the filename, | |||
| * e.g for encrypted file uploads where filename leaks are undesirable. | |||
| * Defaults to false. | |||
There was a problem hiding this comment.
I'm going to bang my, "positive arguments" drum again, ie. if (includeFilename) vs if (!omitFilename)
There was a problem hiding this comment.
But then it's a breaking change unless you mean to default it to true
There was a problem hiding this comment.
yep, suggesting defaulting to true
Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name || file.name= undefined