Add decryption error codes to base.DecryptionError #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
requested changes
Jul 4, 2018
src/crypto/algorithms/megolm.js
Outdated
| @@ -639,6 +642,7 @@ MegolmDecryption.prototype.decryptEvent = async function(event) { | |||
| this._requestKeysForEvent(event); | |||
| } | |||
| throw new base.DecryptionError( | |||
| "OLM_UNKNOWN_MESSAGE_INDEX", | |||
There was a problem hiding this comment.
The error is not necessarily OLM_UNKNOWN_MESSAGE_INDEX here, or at least there is a conditional above that checks for it so I would assume not.
There was a problem hiding this comment.
IRL, me and @lampholder discussed. We don't especially care about all of the errors thrown by decryptGroupMessage (all of which are plain old Error) so I'll just rename this to OLM_GROUP_MESSAGE_ERROR.
There was a problem hiding this comment.
(I changed my mind, we can still emit OLM_UNKNOWN_MESSAGE_INDEX)
dbkr
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should roughly follow https://github.com/matrix-org/matrix-ios-sdk/blob/9732cf593206a10d2b60cd01151a759c88c1e9a2/MatrixSDK/Crypto/Algorithms/MXDecryptionResult.h#L21-L39