Lazy loading: avoid loading members at initial sync for e2e rooms #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate events we were only bailing out when receiving a non JSON-identical m.room.encryption event. When receiving an identical event, the algorithm in _roomEncryptors would be reset, generating a new megolm session every time this happens (there is a LL synapse bug where this happens on every sync). As the _roomList is backed by indexeddb you might already have a config without the algorithm being present though, so we first check for the room encryptor algorithm being present. If so, always bail out as setRoomEncryption was already called for the given room. If no algorithm is present, still check if the config is not being changed. Also setup the roomlist and room encryption synchronously before awaiting the indexeddb operation to store the room encryption config in roomlist.
bwindels
force-pushed
the
bwindels/fixlle2ememberfetch-bis
branch
from
0cda95d
to
4cfdaaf
Compare
This reverts commit 5cf2ebe.
…mDeviceTrackingState
bwindels
force-pushed
the
bwindels/fixlle2ememberfetch-bis
branch
from
4cfdaaf
to
7d00c0b
Compare
without LL, we could refresh the device list before all members have been tracked. as promises, even resolved ones (in case of no LL), always continue async
|
This should be ready to have a look now |
|
Ideally I wanted to add some devicelist integration tests to this as well, with LL enabled, but couldn't figure out how the http mocking is supposed to work, so I'll do it in another PR. |
|
Addresses element-hq/element-web#7182 (Item 2 in the list) |
|
why would you need http mocking for e2e tests btw? |
|
@ara4n Not sure if you're think of the e2e tests. I mean the integration tests for e2e encryption device lists (e.g. |
|
Started writing a test on |
dbkr
reviewed
Aug 28, 2018
src/crypto/RoomList.js
Outdated
| @@ -71,6 +71,9 @@ export default class RoomList { | |||
| } | |||
|
|
|||
| async setRoomEncryption(roomId, roomInfo) { | |||
| // important that this happens before calling into the store | |||
| // as it prevents the Crypto::setRoomEncryption for calling | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.