Fix filepanel also filtering main timeline with LL turned on. #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks plausible. would be good to get a comment about why this is needed though (as i'm failing to see why/where the timeline filter ever gets written into this object?) |
|
@ara4n Here: 3363cc4#diff-cf27c1d543e886c89cd9ac8b8aeaf05bR2154 If the method got called once with both the LL & timeline filter (anytime you open the filepanel with LL enabled), the timeline filter would modify the original LL filter object, persisting the filepanel filter on the LL filter. |
|
right. lgtm then - just need to get the comment in the code to spell out where the 'bad' assign happens to avoid someone breaking it or getting confused by it in future. |
|
Right, will do! |
|
@ara4n ready for another look |
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#7262