Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only emit CATCHUP if recovering from conn error #727

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Only emit CATCHUP if recovering from conn error #727

merged 2 commits into from
Sep 7, 2018

Commits on Sep 7, 2018

  1. Only emit CATCHUP if recovering from conn error 

    Have the keepalive promise return a boolean indicating whether it
detected a connectivity failure or not. Use this to only emit
CATCHUP if there was a connectivity error, to try & suppress
the state flip-flopping back & forth between CATCHUP and ERROR
in the case where we have connectivity but the sync is returning
and error for whatever reason.
    @dbkr
    dbkr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    affdfcc View commit details
    Browse the repository at this point in the history

  2. Include 404 in connectivity success error codes

    @dbkr
    dbkr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    7e8f25b View commit details
    Browse the repository at this point in the history