You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does quite a few sweeping changes to support fetch, CBOR encoding and the Accept header which is part of matrix-org/matrix-spec-proposals#1740. Please do not merge or review this just yet
Anyway, this PR seems to work perfectly fine with a few issues noted below.
Notable failings:
supportsCbor is always true, and not detected. Ergo, this PR breaks support for regular JSON servers.
I had to swap request for fetch because I could not get ArrayBuffer responses out of it which is important.
borc is the library we are using for cbor and is wasmy, untested, and seems to work most of the time.
This change is marked as an internal change (Task), so will not be included in the changelog.
The related MSC hasn't gone anywhere for a few years but fetch support would be good to have. Might be advisable to break out the CBOR-related components to make this more atomic.
It appears that native fetch support has been merged in Node.js quite recently, nodejs/node#41749
Noteworthy that the v18+ implementation is provided by undici, so using that as a polyfill for runtimes without fetch support should ensure minimal differences.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does quite a few sweeping changes to support
fetch,CBOR encodingand theAcceptheader which is part of matrix-org/matrix-spec-proposals#1740. Please do not merge or review this just yetAnyway, this PR seems to work perfectly fine with a few issues noted below.
Notable failings:
supportsCboris always true, and not detected. Ergo, this PR breaks support for regular JSON servers.requestfor fetch because I could not get ArrayBuffer responses out of it which is important.borcis the library we are using forcborand is wasmy, untested, and seems to work most of the time.This change is marked as an internal change (Task), so will not be included in the changelog.