Document checking crypto state before using hasUnverifiedDevices
#889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear what `hasUnverifiedDevices` should do when crypto is disabled on the current device. Let's at least document that callers should first check crypto status.
jryans
added a commit
to jryans/matrix-react-sdk
that referenced
this pull request
Apr 8, 2019
When crypto is disabled for the current device, we can't tell whether there are unverified devices since we aren't tracking devices at all. Let's be safe and default to the warning state. See also matrix-org/matrix-js-sdk#889
dbkr
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear what
hasUnverifiedDevicesshould do when crypto is disabled onthe current device. Let's at least document that callers should first check
crypto status.