Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag v3 rooms as safe #893

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Flag v3 rooms as safe #893

merged 2 commits into from
Apr 9, 2019

Conversation

turt2live
Copy link
Member

The spec says they are, so we might as well too.

@turt2live
Flag v3 rooms as safe
3aa8bfa 
The spec says they are, so we might as well too.
@turt2live turt2live requested a review from a team April 9, 2019 15:25
@turt2live turt2live mentioned this pull request Apr 9, 2019
Merged
jryans
jryans approved these changes Apr 9, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking it out. Seems good to me! 😁

src/models/room.js Show resolved Hide resolved
@turt2live turt2live merged commit b051361 into develop Apr 9, 2019
@turt2live turt2live deleted the travis/v3-safe branch April 9, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @jryans