Don't reset the timeline when we join a room after peeking #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we've already got all the events in a limited sync, there is no need to reset the timeline.
|
OK, think I've got my head around this! lgtm. |
richvdh
added a commit
that referenced
this pull request
Mar 1, 2016
…_join Don't reset the timeline when we join a room after peeking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we've already got all the events in a limited sync, there is no need to reset
the timeline.
This fixes a bug where, if you peek into a world-readable room, and then join it, we get stuck paginating in a tight loop until an event arrives (or you change room).
I think this is probably also responsible for a number of other bugs, like element-hq/element-web#1045 and element-hq/element-web#943, though I haven't yet reproduced those fully.