Fix backup sig validation with multiple sigs #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verifySignature modifies the object so we need to clone if we're verifying more than one signature. Fixes element-hq/element-web#9357
jryans
approved these changes
Jun 7, 2019
| @@ -371,7 +371,9 @@ Crypto.prototype.isKeyBackupTrusted = async function(backupInfo) { | |||
| try { | |||
| await olmlib.verifySignature( | |||
| this._olmDevice, | |||
| backupInfo.auth_data, | |||
| // verifySignature modifies the object so we need to copy | |||
There was a problem hiding this comment.
This is fine as a workaround, but maybe verifySignature should also be changed to not do that...? (It seems like other might also be confused by it...)
There was a problem hiding this comment.
Yeah - I'm slightly hesitant to do it without fully understanding why it was done like that, although I suspect just for speed.
t3chguy
deleted the
dbkr/verify_signature_modifies_the_object_because_everything_is_awful
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifySignature modifies the object so we need to clone if we're
verifying more than one signature.
Fixes element-hq/element-web#9357