Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle associated event send failures #972

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Handle associated event send failures #972

merged 4 commits into from
Jul 3, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Jul 2, 2019 •
edited
Loading

@bwindels
keep local redaction event to return accurate status
dc3d90d
@bwindels
expose local echo redaction event on redacted event
6ea4c77
@bwindels
clarify when this will return something
a4591af
@bwindels
allow to clear replacement on redacted events
8eeb088 
this is needed when cancelling sending anything related to an event,
to not keep the event as edited when we cancel the edit
before the redaction.
@bwindels bwindels mentioned this pull request Jul 2, 2019
Merged
@bwindels bwindels requested a review from a team July 2, 2019 15:39
@bwindels bwindels merged commit 4f4d694 into develop Jul 3, 2019
@t3chguy t3chguy deleted the bwindels/handle-associated-failures branch May 10, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwindels @turt2live