Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default push rule to ignore reactions #976

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jul 4, 2019

This adds a default push rule to ignore reactions as proposed in
MSC2153. By adding it here
in the client directly, we can try out the idea early even if it hasn't appeared
in the user's HS yet.

Part of element-hq/element-web#10208

This adds a default push rule to ignore reactions as proposed in
[MSC2153](matrix-org/matrix-spec-proposals#2153). By adding it here
in the client directly, we can try out the idea early even if it hasn't appeared
in the user's HS yet.

Part of element-hq/element-web#10208
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a code perspective. Does this need a react-sdk component similar to the tombstone (or are we okay with it being one of the many hidden options)?

I would want a checkmark from Dave on either this or the MSC before calling this safe to merge though.

@jryans
Copy link
Collaborator Author

jryans commented Jul 4, 2019

Does this need a react-sdk component similar to the tombstone (or are we okay with it being one of the many hidden options)?

I think it's okay for it to be hidden for the moment. If we later find out that there in fact are many people who want reactions to notify, we can expose an option for that.

@jryans
Copy link
Collaborator Author

jryans commented Jul 5, 2019

Dave has approved the MSC, so I'll proceed with landing this.

@jryans jryans merged commit 90e2586 into develop Jul 5, 2019
jryans added a commit to matrix-org/synapse that referenced this pull request Jul 5, 2019
jryans added a commit to matrix-org/synapse that referenced this pull request Jul 5, 2019
@t3chguy t3chguy deleted the jryans/push-rule-reactions branch May 10, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants