Fix not hiding redacted edits #978
Conversation
| // difference between a redacted edit and message | ||
| const relation = this.getRelation(); | ||
| if (relation) { | ||
| this._relationTypeBeforeRedaction = relation.rel_type; |
There was a problem hiding this comment.
is this field persisted? Concern would be it showing correctly at the time it happened, but when switching rooms or refreshing the page the double redaction comes back.
There was a problem hiding this comment.
Don't think it needs to be. All events are kept in memory, so switching rooms shouldn't clear this.
As for refreshing the page, both the edit and its redaction should be loaded in the same order when processing the sync accumulator blob, so that should also work.
There was a problem hiding this comment.
Argh, you might be right. Just saw them popup again (fetched through /messages I presume). I was assuming redacted messages wouldn't show up through /messages, but looks like that is not the case... will discuss in the reactions channel...
|
This needs backend support to solve properly, see matrix-org/matrix-spec-proposals#2154 (comment) |
Fixes https://github.com/vector-im/riot-web/issues/10112
Preserves rel_type after redacting an edit, so we still know it wasn't a normal message