Enable redirected media by default (#12142)

* Enable redirected media by default See matrix-org/matrix-js-sdk#4007 * Update the tests * Update tests * Update end-to-end tests too * Update linkifier to use Media customisation endpoint * Fix tests for new js-sdk behaviour * Fix unchanged file * Fix linkifier * Fix lint
matrix-org · Feb 11, 2024 · 86b3564 · 86b3564
1 parent d192807
commit 86b3564
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/playwright/e2e/timeline/timeline.spec.ts b/playwright/e2e/timeline/timeline.spec.ts
@@ -49,7 +49,7 @@ const expectAvatar = async (cli: Client, e: Locator, avatarUrl: string): Promise
     const url = await cli.evaluate(
         (client, { avatarUrl, size, resizeMethod }) => {
             // eslint-disable-next-line no-restricted-properties
-            return client.mxcUrlToHttp(avatarUrl, size, size, resizeMethod);
+            return client.mxcUrlToHttp(avatarUrl, size, size, resizeMethod, false, true);
         },
         { avatarUrl, size, resizeMethod: AVATAR_RESIZE_METHOD },
     );

diff --git a/src/customisations/Media.ts b/src/customisations/Media.ts
@@ -80,7 +80,7 @@ export class Media {
      */
     public get srcHttp(): string | null {
         // eslint-disable-next-line no-restricted-properties
-        return this.client.mxcUrlToHttp(this.srcMxc) || null;
+        return this.client.mxcUrlToHttp(this.srcMxc, undefined, undefined, undefined, false, true) || null;
     }
 
     /**
@@ -90,7 +90,7 @@ export class Media {
     public get thumbnailHttp(): string | null {
         if (!this.hasThumbnail) return null;
         // eslint-disable-next-line no-restricted-properties
-        return this.client.mxcUrlToHttp(this.thumbnailMxc!);
+        return this.client.mxcUrlToHttp(this.thumbnailMxc!, undefined, undefined, undefined, false, true);
     }
 
     /**
@@ -107,7 +107,7 @@ export class Media {
         width = Math.floor(width * window.devicePixelRatio);
         height = Math.floor(height * window.devicePixelRatio);
         // eslint-disable-next-line no-restricted-properties
-        return this.client.mxcUrlToHttp(this.thumbnailMxc!, width, height, mode);
+        return this.client.mxcUrlToHttp(this.thumbnailMxc!, width, height, mode, false, true);
     }
 
     /**
@@ -122,7 +122,7 @@ export class Media {
         width = Math.floor(width * window.devicePixelRatio);
         height = Math.floor(height * window.devicePixelRatio);
         // eslint-disable-next-line no-restricted-properties
-        return this.client.mxcUrlToHttp(this.srcMxc, width, height, mode);
+        return this.client.mxcUrlToHttp(this.srcMxc, width, height, mode, false, true);
     }
 
     /**

diff --git a/src/linkify-matrix.ts b/src/linkify-matrix.ts
@@ -184,7 +184,15 @@ export const options: Opts = {
         switch (type) {
             case "url":
                 if (href.startsWith("mxc://") && MatrixClientPeg.get()) {
-                    return getHttpUriForMxc(MatrixClientPeg.get()!.baseUrl, href);
+                    return getHttpUriForMxc(
+                        MatrixClientPeg.get()!.baseUrl,
+                        href,
+                        undefined,
+                        undefined,
+                        undefined,
+                        false,
+                        true,
+                    );
                 }
             // fallthrough
             case Type.RoomAlias: