Standardise the margin for settings tabs (#7963)

Co-authored-by: Michael Telatynski <[email protected]>
matrix-org · May 12, 2022 · ab26aad · ab26aad
1 parent 25428b0
commit ab26aad
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/res/css/views/settings/_ProfileSettings.scss b/res/css/views/settings/_ProfileSettings.scss
@@ -28,12 +28,6 @@ limitations under the License.
 .mx_ProfileSettings_controls {
     flex-grow: 1;
     margin-right: 54px;
-
-    // We put the header under the controls with some minor styling to cheat
-    // alignment of the field with the avatar
-    .mx_SettingsTab_subheading {
-        margin-top: 0;
-    }
 }
 
 .mx_ProfileSettings_controls .mx_Field #profileTopic {

diff --git a/res/css/views/settings/tabs/_SettingsTab.scss b/res/css/views/settings/tabs/_SettingsTab.scss
@@ -27,6 +27,7 @@ limitations under the License.
     font-weight: 600;
     color: $primary-content;
     margin-bottom: 10px;
+    margin-top: 10px;
 }
 
 .mx_SettingsTab_heading:nth-child(n + 2) {

diff --git a/res/css/views/settings/tabs/user/_AppearanceUserSettingsTab.scss b/res/css/views/settings/tabs/user/_AppearanceUserSettingsTab.scss
@@ -21,6 +21,7 @@ limitations under the License.
 .mx_AppearanceUserSettingsTab {
     > .mx_SettingsTab_SubHeading {
         margin-bottom: 32px;
+        margin-top: 12px;
     }
 }
 

diff --git a/res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss b/res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss
@@ -27,6 +27,9 @@ limitations under the License.
 }
 
 .mx_SecurityUserSettingsTab {
+    .mx_SettingsTab_heading {
+        margin-bottom: 22px;
+    }
     .mx_SettingsTab_section {
         .mx_AccessibleButton_kind_link {
             padding: 0;

diff --git a/res/css/views/settings/tabs/user/_SidebarUserSettingsTab.scss b/res/css/views/settings/tabs/user/_SidebarUserSettingsTab.scss
@@ -16,7 +16,7 @@ limitations under the License.
 
 .mx_SidebarUserSettingsTab {
     .mx_SettingsTab_section {
-        margin-top: 10px;
+        margin-top: 12px;
     }
 
     .mx_SidebarUserSettingsTab_subheading {