Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

#24023 Update _HelpUserSettingsTab.pcss #10059

Closed
wants to merge 1 commit into from

Conversation

sbjaj33
Copy link
Contributor

@sbjaj33 sbjaj33 commented Feb 2, 2023

Updated _HelpUserSettingsTab.pcss File, made the access key field scroll able as required for some cases when access key is longer it overflows out of border. ( Tested this logic on google devtools online )

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Updated _HelpUserSettingsTab.pcss File, made the access key field scroll able as required for some cases when access key is longer it overflows out of border.
( Tested this logic on google devtools online )
@dbkr
Copy link
Member

dbkr commented Feb 2, 2023

Thanks for the PR! However, there are some things that need fixing about it. We encourage you to read CONTRIBUTING.md which gives instructions on how to make a good pull request. Looking at the format of other pull requests on the repository should help too. In particular, remember:

  • Your PR title will appear in the changelog: make sure it's a good, short description of what your PR does.
  • If it fixes an issue, use standard GitHub syntax ("fixes [link to issue]") in the description (not in the title).
  • Visual changes needs before and after screenshots.
  • Your PR needs DCO signoff. Checking the check box is not sufficient.

We'd welcome a new PR after fixing these issues.

@dbkr dbkr closed this Feb 2, 2023
@sbjaj33
Copy link
Contributor Author

sbjaj33 commented Feb 3, 2023

@dbkr , Thanks for insight , I have successfully made new PR , Please check #10069

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants