Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow creating permalinks for unknown predecessor rooms (even though unlikely to be successful) #10113

Closed
wants to merge 2 commits into from
Closed

Allow creating permalinks for unknown predecessor rooms (even though unlikely to be successful) #10113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7174f03
Allow creating permalinks for unknown predecessor rooms (even though …
justjanne Feb 8, 2023
7404c53
Improve warning message
justjanne Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/components/views/messages/RoomPredecessorTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,13 @@ export const RoomPredecessorTile: React.FC<IProps> = ({ mxEvent, timestamp }) =>
}

const prevRoom = MatrixClientPeg.get().getRoom(predecessor.roomId);
if (!prevRoom) {
logger.warn(`Failed to find predecessor room with id ${predecessor.roomId}`);
return <></>;
}
const permalinkCreator = new RoomPermalinkCreator(prevRoom, predecessor.roomId);
permalinkCreator.load();
if (prevRoom) {
permalinkCreator.load();
} else {
logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId},`+
'unlikely to be successful as rooms without via servers are usually not routable');
}
let predecessorPermalink: string;
if (predecessor.eventId) {
predecessorPermalink = permalinkCreator.forEvent(predecessor.eventId);
Expand Down