This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Edit a test to check timestamp color's value on timeline and thread panel #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <[email protected]>
…hreadView Signed-off-by: Suguru Hirahara <[email protected]>
github-actions
bot
added
Z-Community-PR
luixxiul
commented
Mar 2, 2023
| @@ -130,7 +130,7 @@ limitations under the License. | |||
| } | |||
|
|
|||
| .mx_MessageTimestamp { | |||
| color: $event-timestamp-color; | |||
| color: var(--MessageTimestamp-color); /* TODO: check whether needed or not */ | |||
There was a problem hiding this comment.
It is not sure if this declaration would be really required. After having more extensive test sets which check visual regressions overall, it might be fine to remove it.
dbkr
approved these changes
Mar 2, 2023
|
@luixxiul github appears to be having a blip. Can you try merging latest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to replace a variable with CSS native one and edit a test to check whether the message timestamp color's value is consistent on main timeline and thread panel (
ThreadViewandThreadPanel). Percy tests should not work here because the timestamp string varies every time you run the test. See: element-hq/element-web#22699type: task
Signed-off-by: Suguru Hirahara [email protected]
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.