Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Conform more code to strictNullChecks #10374

Merged
merged 12 commits into from
Mar 16, 2023
Merged

Conform more code to strictNullChecks #10374

merged 12 commits into from
Mar 16, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 14, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#21967
Requires #10366
Requires #10383

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy changed the title t3chguy/tsc-strict5 Conform more code to strictNullChecks Mar 14, 2023
@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 14, 2023
@t3chguy t3chguy self-assigned this Mar 14, 2023
@t3chguy t3chguy marked this pull request as ready for review March 14, 2023 15:46
@t3chguy t3chguy requested review from a team as code owners March 14, 2023 15:46
richvdh
richvdh reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a review on this, and it looks plausible, but... there's a lot of changes and I don't really have time to go through them all. Can we have smaller PRs?

@kerryarchibald kerryarchibald mentioned this pull request Mar 15, 2023
Closed
@t3chguy t3chguy changed the base branch from develop to t3chguy/tsc-strict7 March 15, 2023 09:04
@t3chguy
Copy link
Member Author

t3chguy commented Mar 15, 2023

@richvdh have broken out a chunk into #10383

kerryarchibald
kerryarchibald approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from t3chguy/tsc-strict7 to develop March 16, 2023 10:35
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
07fc088 
… t3chguy/tsc-strict5

# Conflicts:
#	src/components/structures/RoomView.tsx
#	src/rageshake/submit-rageshake.ts
@t3chguy t3chguy merged commit 1c9ea42 into develop Mar 16, 2023
@t3chguy t3chguy deleted the t3chguy/tsc-strict5 branch March 16, 2023 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh left review comments

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne was automatically assigned from matrix-org/element-web-team

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @richvdh @kerryarchibald