This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Handle IDB closed event by showing modal with prompt to reload app (#10395
#10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Enhancement
|
I think for the registration flow we can special-case this to just auto-refresh as you have nothing to lose |
florianduros
approved these changes
Mar 31, 2023
t3chguy
changed the title
closed event by showing modal with prompt to reload appclosed event by showing modal with prompt to reload app (#10395
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#3218
For element-hq/element-web#24831
For the registration case it'll skip the modal and just reload immediately
Here's what your changelog entry will look like:
✨ Features
closedevent by showing modal with prompt to reload app (Handle IDBclosedevent by showing modal with prompt to reload app (#10395 #10395 (#10395).