This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update tests to ensure file size unit has been fixed #10568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <[email protected]>
github-actions
bot
added
Z-Community-PR
t3chguy
approved these changes
Apr 11, 2023
richvdh
suggested changes
Apr 11, 2023
| uploadFile("cypress/fixtures/matrix-org-client-versions.json"); | ||
|
|
||
| cy.get(".mx_FilePanel .mx_EventTile").within(() => { | ||
| // Assert that the file size is displayed in kilobyte, not kibibyte (kB) |
There was a problem hiding this comment.
Suggested change
| // Assert that the file size is displayed in kilobyte, not kibibyte (kB) | |
| // Assert that the file size is displayed in kibibytes (1024 bytes), not kilobytes (1000 bytes) |
There was a problem hiding this comment.
possibly the other references to kilobytes in this PR should be changed to kibibytes too, though it's not too important because "kilobyte" can mean either 1024 bytes or 1000 bytes.
There was a problem hiding this comment.
I understood. I have not known kilobyte could mean both.. 😲
Co-authored-by: Richard van der Hoff <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
|
@richvdh Thanks for the review! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #10561 in order to ensure that file size unit used on a file tile or audio player is kibibytes (1024 bytes), not kilobytes (1000 bytes).
type: task
Signed-off-by: Suguru Hirahara [email protected]
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.