Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

"Show rooms with unread messages first" should not be on by default for new users #10820

Merged
merged 2 commits into from
May 8, 2023
Merged

"Show rooms with unread messages first" should not be on by default for new users #10820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e6e1ff
set default activity ordering to natural for room list
May 8, 2023
88772c9
Merge branch 'develop' into kerry/25304/default-room-list-sort
May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/stores/room-list/RoomListStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ export class RoomListStoreClass extends AsyncStoreWithClient<IState> implements

// logic must match calculateTagSorting
private calculateListOrder(tagId: TagID): ListAlgorithm {
const defaultOrder = ListAlgorithm.Importance;
const defaultOrder = ListAlgorithm.Natural;
const definedOrder = this.getListOrder(tagId);
const storedOrder = this.getStoredListOrder(tagId);

Expand Down
2 changes: 1 addition & 1 deletion test/stores/room-list/RoomListStore-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe("RoomListStore", () => {
});

it.each(OrderedDefaultTagIDs)("defaults to activity ordering for %s=", (tagId) => {
expect(RoomListStore.instance.getListOrder(tagId)).toBe(ListAlgorithm.Importance);
expect(RoomListStore.instance.getListOrder(tagId)).toBe(ListAlgorithm.Natural);
});

function createStore(): { store: RoomListStoreClass; handleRoomUpdate: jest.Mock<any, any> } {
Expand Down