This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use classNames function for appTileBodyClass on AppTile.tsx
#10939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
florianduros
suggested changes
May 19, 2023
| @@ -590,7 +590,11 @@ export default class AppTile extends React.Component<IProps, IState> { | |||
| const iframeFeatures = | |||
| "microphone; camera; encrypted-media; autoplay; display-capture; clipboard-write; " + "clipboard-read;"; | |||
|
|
|||
| const appTileBodyClass = "mx_AppTileBody" + (this.props.miniMode ? "_mini " : " "); | |||
| const appTileBodyClass = classNames({ | |||
| mx_AppTileBody: !this.props.miniMode, | |||
There was a problem hiding this comment.
mx_AppTileBody is always is present in the previous version
There was a problem hiding this comment.
No, because "mx_AppTileBody" + (this.props.miniMode ? "_mini " outputs "mx_AppTileBody_mini " on miniMode.
If miniMode is not enabled, mx_AppTileBody (mind the last white space character) is output.
Here is the how the class name is output on develop.element.io:
florianduros
approved these changes
May 19, 2023
|
Thanks for the review! |
|
@florianduros would you please add to the merge queue? |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to use
classNamesfunction forappTileBodyClassonAppTile.tsxto improve maintainability, instead of joining class names with white space characters.mx_AppTileBody(Mind the white space character at the end of the class name)
mx_AppTile_loadingmx_AppTileBody_mini(Mind the white space character at the end of the class name)
The class names will be conformed to our naming policy later.
type: task
Signed-off-by: Suguru Hirahara [email protected]
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.