Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move session manager out of beta #10968

Merged
merged 8 commits into from
May 26, 2023
Merged

Move session manager out of beta #10968

merged 8 commits into from
May 26, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 23, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25422

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 23, 2023
kerryarchibald
kerryarchibald commented May 23, 2023
View reviewed changes
test/components/views/settings/tabs/user/SecurityUserSettingsTab-test.tsx
expect(queryByTestId("devices-section")).toBeFalsy();
});

it("renders qr code login section", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalent QR tests are already in SessionManagerTab tests

@odelcroi
Copy link
Contributor

Hi @kerryarchibald,
Thanks for the work with the new session manager.
We haven't work on it yet, would that be possible to keep the old session manager with a feature flag for a while?
Thanks

@t3chguy
Copy link
Member

t3chguy commented May 23, 2023

@odelcroi we are very unlikely to keep old code around once we have new code to replace it, the maintenance burden is just too high. I'd suggest forking if you need to maintain old code.

@kerryarchibald kerryarchibald requested a review from a team May 23, 2023 21:09
@daniellekirkwood
Copy link

We had a discussion about this in the PM room. @jakewb-b who has previously worked on the feature as PM is in favour of de-labsing. @pmaier1 has some questions about the state of the experimental back-end features.

Do we have line of sight to when these things won't be experimental anymore? I'm not close enough on this to know - otherwise happy to approve :)

Screenshot 2023-05-25 at 09 28 41

@Johennes
Copy link
Contributor

Do we have line of sight to when these things won't be experimental anymore?

The experimental features (MSC3852 & MSC3881) are plug-in and cover functionality that the old session manager did not have. These shouldn't block us from landing the new session manager IMO.

@kerryarchibald kerryarchibald marked this pull request as ready for review May 25, 2023 10:42
@kerryarchibald kerryarchibald requested a review from a team as a code owner May 25, 2023 10:42
pmaier1
pmaier1 approved these changes May 25, 2023
View reviewed changes
Copy link

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

t3chguy
t3chguy approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kerryarchibald kerryarchibald added this pull request to the merge queue May 26, 2023
Merged via the queue into develop with commit 530197b May 26, 2023
@kerryarchibald kerryarchibald deleted the kerry/25422/delabs-session-manager branch May 26, 2023 02:22
@kerryarchibald kerryarchibald mentioned this pull request Jun 1, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmaier1 pmaier1 pmaier1 approved these changes

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kerryarchibald @odelcroi @t3chguy @daniellekirkwood @Johennes @pmaier1