This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add theme data to EC widget Url #12279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/theme-data-to-widget
branch
2 times, most recently
from
0781364
to
d5e0614
Compare
toger5
force-pushed
the
toger5/theme-data-to-widget
branch
from
d5e0614
to
cbb7813
Compare
Signed-off-by: Timo K <[email protected]>
toger5
force-pushed
the
toger5/theme-data-to-widget
branch
from
cbb7813
to
da09338
Compare
toger5
added
the
T-Enhancement
dbkr
approved these changes
Feb 22, 2024
I was considering it. I really feel like this is part of the widget api code. (here we really just concatenate the url props) |
Signed-off-by: Timo K <[email protected]>
|
@t3chguy I added testing this by extending the already existing url generation test. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 13, 2024
https://build.opensuse.org/request/show/1157523 by user dheidler + anag+factory - Version 1.11.60 ## ✨ Features * Refine styles of controls to match Compound (matrix-org/matrix-react-sdk#12299). Contributed by @robintown. * Hide the archived section (matrix-org/matrix-react-sdk#12286). Contributed by @dbkr. * Add theme data to EC widget Url (matrix-org/matrix-react-sdk#12279). Contributed by @toger5. * Update MSC2965 OIDC Discovery implementation (matrix-org/matrix-react-sdk#12245). Contributed by @t3chguy. * Use green dot for activity notification in `LegacyRoomHeader` (matrix-org/matrix-react-sdk#12270). Contributed by @florianduros. ## 🐛 Bug Fixes * Fix requests for senders to submit auto-rageshakes (https://github.com/matrix-org/ma
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 13, 2024
https://build.opensuse.org/request/show/1157524 by user dheidler + anag+factory - Version 1.11.60 ## ✨ Features * Refine styles of controls to match Compound (matrix-org/matrix-react-sdk#12299). Contributed by @robintown. * Hide the archived section (matrix-org/matrix-react-sdk#12286). Contributed by @dbkr. * Add theme data to EC widget Url (matrix-org/matrix-react-sdk#12279). Contributed by @toger5. * Update MSC2965 OIDC Discovery implementation (matrix-org/matrix-react-sdk#12245). Contributed by @t3chguy. * Use green dot for activity notification in `LegacyRoomHeader` (matrix-org/matrix-react-sdk#12270). Contributed by @florianduros. ## 🐛 Bug Fixes * Fix requests for senders to submit auto-rageshakes (https://github.com/matrix-org/ma
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timo K [email protected]
Since the widget driver will replace the template variable
$org.matrix.msc2873.client_themewith whatever is required as the theme this is enoght to pass?theme=light(dark,...) to the widget as expected by element-call.Checklist