This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Align RoomSummaryCard styles with Figma #12793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Enhancement
t3chguy
force-pushed
the
t3chguy/pass-room-summary-card
branch
from
fc6b8c2
to
601b69f
Compare
t3chguy
force-pushed
the
t3chguy/pass-room-summary-card
branch
from
601b69f
to
2e30258
Compare
Closed
7 tasks
richvdh
previously requested changes
Jul 23, 2024
There was a problem hiding this comment.
Generally lgtm. A few nits about documentation and others.
Thanks for making the effort to help review by breaking it down into smaller commits - that definitely helped. Though I would say it feels like it could have been two PRs - one to move the extensions to a new tab, and another to do the other rearrangements to the summary card.
| @@ -32,10 +32,8 @@ limitations under the License. | |||
| &::before { | |||
| /* Bloom using magic numbers directly out of Figma */ | |||
| content: ""; | |||
| display: block; | |||
There was a problem hiding this comment.
if you're asking someone to review commit-by-commit, it would be nice to fix up the commits rather than giving the reviewer "Iterate" commits to review.
git-absorb may be helpful here. YMMV.
There was a problem hiding this comment.
Yeah sorry this PR ended up a mess as I ended up splitting out EmptyState as another PR needed it and then forgot to rebase here. Do keep meaning to try git-absorb, thanks
t3chguy
force-pushed
the
t3chguy/pass-room-summary-card
branch
from
2648b45
to
2c1c3ce
Compare
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
force-pushed
the
t3chguy/pass-room-summary-card
branch
from
2c1c3ce
to
18f501b
Compare
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
… t3chguy/pass-room-summary-card # Conflicts: # src/components/views/rooms/RoomInfoLine.tsx
t3chguy
requested review from
a team,
dbkr and
robintown
and removed request for
a team
… t3chguy/pass-room-summary-card Signed-off-by: Michael Telatynski <[email protected]> # Conflicts: # playwright/snapshots/crypto/crypto.spec.ts/RoomSummaryCard-with-verified-e2ee-linux.png # playwright/snapshots/right-panel/right-panel.spec.ts/with-name-and-address-linux.png
dbkr
approved these changes
Aug 1, 2024
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 9, 2024
https://build.opensuse.org/request/show/1196036 by user dheidler + anag+factory - Version 1.11.75 # Security - Fixes for GHSA-vhr5-g3pm-49fm (CVE-2024-42369). - Version 1.11.74 ## ✨ Features * Update unsupported browser react component to new designs (element-hq/element-web#27857). Contributed by @t3chguy. * Invite dialog: display MXID on its own line (matrix-org/matrix-react-sdk#11756). Contributed by @AndrewFerr. * Align RoomSummaryCard styles with Figma (matrix-org/matrix-react-sdk#12793). Contributed by @t3chguy. * Extract Extensions into their own right panel tab (matrix-org/matrix-react-sdk#12844). Contributed by @t3chguy. * Remove topic from new room header and expand right panel topic (http
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 9, 2024
https://build.opensuse.org/request/show/1196035 by user dheidler + anag+factory - Version 1.11.75 * Fixes for CVE-2024-42369 / GHSA-vhr5-g3pm-49fm. - Version 1.11.74 ## ✨ Features * Update unsupported browser react component to new designs (element-hq/element-web#27857). Contributed by @t3chguy. * Invite dialog: display MXID on its own line (matrix-org/matrix-react-sdk#11756). Contributed by @AndrewFerr. * Align RoomSummaryCard styles with Figma (matrix-org/matrix-react-sdk#12793). Contributed by @t3chguy. * Extract Extensions into their own right panel tab (matrix-org/matrix-react-sdk#12844). Contributed by @t3chguy. * Remove topic from new room header and expand right panel topic (matrix-org/matrix-react-sdk#12842). Contributed by @t3c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/element-hq/wat-internal/issues/166
Requires #12796Requires #12843Review commit-by-commit
Designs https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2/Room-Header-%26-Details-(2024)?node-id=0-1&t=NCusToRsR4Vju4OT-0