This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Fixed custom emotes background color #27745 #12798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
Issue is solved by a community member's PR
label
Jul 19, 2024
t3chguy
added
the
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
label
Jul 19, 2024
t3chguy
suggested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me, could you add a comment to the style so its clear to future readers why this override exists
The reason the tests are failing is due to your fork of https://github.com/asimdelvi/element-web being out of date, could you sync that up so the fork matching doesn't fail :) |
yep, updated the branch. |
You checked |
Signed-off-by: Asim Mohammed Delvi [email protected] |
thanks for the guidance @t3chguy |
t3chguy
approved these changes
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
Z-Community-PR
Issue is solved by a community member's PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public
/exported
symbols have accurate TSDoc documentation.fixes element-hq/element-web#27745
in github-markdown-css, img background is set to #fff for light theme and #000 for dark theme. So had to override the styling.