-
-
Notifications
You must be signed in to change notification settings - Fork 833
Display pinned messages on a banner at the top of a room #12917
Conversation
a6bb865
to
f341ee2
Compare
f341ee2
to
23b39af
Compare
5c26f96
to
0e3c560
Compare
0e3c560
to
1f9dde9
Compare
1f9dde9
to
b5895b4
Compare
b5895b4
to
6ce4cc8
Compare
4a1c939
to
3af777d
Compare
3af777d
to
a7713bf
Compare
a7713bf
to
595928b
Compare
a8f359e
to
809790d
Compare
809790d
to
86488a6
Compare
} | ||
|
||
// Handle poll events | ||
await room.processPollEvents([event]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, really feels like this is pulling logic out of the js-sdk and duplicating it here. Is there any way we could let the js-sdk do all this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I copy pasta this logic from the previous impl of pinning. You are talking about the manual event fetching right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbkr My proposition is leave this duplication here since the duplication existed before this PR. And I'll make a dedicated PR to move all the ( https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/messages/MPollEndBody.tsx#L41 ) duplicates into the js-sdk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds ideal if you have the time - thank you!
Checklist
public
/exported
symbols have accurate TSDoc documentation.Part of https://github.com/element-hq/element-internal/issues/609
Figma https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=24-126291&t=21A0TwvtjtfbAidQ-0