Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Sort the pinning message list in the same order than the banner. By timeline order. #12937

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Sort the pinning message list in the same order than the banner. By timeline order. #12937

merged 2 commits into from
Aug 30, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 29, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Change the sorting of the pinning message list to match the banner.
Before it was sorted by pinning order, now it's sorted by the order in the timeline.

@florianduros florianduros force-pushed the florianduros/pinned-messages/list-ordering branch from c3194b1 to f5aab67 Compare August 29, 2024 14:47
@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 29, 2024
@florianduros florianduros force-pushed the florianduros/pinned-messages/list-ordering branch from f5aab67 to 9d4f658 Compare August 29, 2024 15:22
@florianduros florianduros marked this pull request as ready for review August 29, 2024 15:37
@florianduros florianduros requested a review from a team as a code owner August 29, 2024 15:37
@florianduros florianduros changed the title Sort the pinning message list in the same order than the banner Sort the pinning message list in the same order than the banner. By timeline order. Aug 29, 2024
@florianduros florianduros added this pull request to the merge queue Aug 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2024
@florianduros florianduros added this pull request to the merge queue Aug 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 30, 2024
@florianduros
Sort the pinning message list in the same order than the banner (#12937)
eacee88
@florianduros florianduros removed this pull request from the merge queue due to a manual request Aug 30, 2024
@florianduros florianduros added this pull request to the merge queue Aug 30, 2024
Merged via the queue into develop with commit 13ec19c Aug 30, 2024
29 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/list-ordering branch August 30, 2024 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr