Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add error handling for room publish toggle #12941

Conversation

sahil9001
Copy link
Contributor

@sahil9001 sahil9001 commented Sep 1, 2024

Fixes element-hq/element-web#27981

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@sahil9001 sahil9001 requested a review from a team as a code owner September 1, 2024 10:41
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 1, 2024
src/components/views/room_settings/RoomPublishSetting.tsx Outdated Show resolved Hide resolved
src/components/views/room_settings/RoomPublishSetting.tsx Outdated Show resolved Hide resolved
src/components/views/room_settings/RoomPublishSetting.tsx Outdated Show resolved Hide resolved
src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved
@sahil9001 sahil9001 requested a review from dbkr September 2, 2024 13:32
@sahil9001
Copy link
Contributor Author

@dbkr also I can't add labels to this PR, can you add one which seems suitable?

@sahil9001 sahil9001 requested a review from dbkr September 2, 2024 16:20
@dbkr dbkr changed the title feat: added error handling for room publish toggle Add error handling for room publish toggle Sep 3, 2024
@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 3, 2024
@dbkr
Copy link
Member

dbkr commented Sep 3, 2024

Oh, and you'll need to run yarn run i18n rather than manually adding the entries to the file since the CI checks that it gets the same result.

@sahil9001
Copy link
Contributor Author

done please check @dbkr

@dbkr
Copy link
Member

dbkr commented Sep 4, 2024

Just need to run prettier now (this is why the ESLint check is failing) and I think this will be good to go.

@sahil9001
Copy link
Contributor Author

Ran the lint command as well, @dbkr

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through the various steps! We got there!

@dbkr dbkr added this pull request to the merge queue Sep 5, 2024
Merged via the queue into matrix-org:develop with commit cdffbdb Sep 5, 2024
26 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When "Publish this room to the public in matrix.org's room directory?" fails it should display why
2 participants