This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Add error handling for room publish toggle #12941
Merged
dbkr
merged 7 commits into
matrix-org:develop
from
sahil9001:27981-add-error-dialog-for-room-publish-toggle
Sep 5, 2024
Merged
Add error handling for room publish toggle #12941
dbkr
merged 7 commits into
matrix-org:develop
from
sahil9001:27981-add-error-dialog-for-room-publish-toggle
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
Issue is solved by a community member's PR
label
Sep 1, 2024
dbkr
suggested changes
Sep 2, 2024
@dbkr also I can't add labels to this PR, can you add one which seems suitable? |
dbkr
reviewed
Sep 2, 2024
dbkr
changed the title
feat: added error handling for room publish toggle
Add error handling for room publish toggle
Sep 3, 2024
dbkr
added
the
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
label
Sep 3, 2024
Oh, and you'll need to run |
…rror-dialog-for-room-publish-toggle
done please check @dbkr |
Just need to run prettier now (this is why the ESLint check is failing) and I think this will be good to go. |
…alog-for-room-publish-toggle
Ran the lint command as well, @dbkr |
dbkr
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through the various steps! We got there!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
Z-Community-PR
Issue is solved by a community member's PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#27981
Checklist
public
/exported
symbols have accurate TSDoc documentation.