This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add interactive tooltip style #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of reactions and editing work, we're adding a new style of tooltip that allows interacting with the content of the tooltip. `ContextualMenu` is closest out of the things we have today, but it doesn't position in quite the way we want and it's already quite complex. To get started, let's first clone that to a new `InteractiveTooltip`. Part of element-hq/element-web#9753 Part of element-hq/element-web#9716
This adjusts the positioning to work more the way we want: * Tooltip is position on the top or bottom edge of the target depending on where space is available * Tooltip and chevron are centered In addition, more bits borrowed from `ContextualMenu` are not needed, so they have been removed for simplicity. Part of element-hq/element-web#9753 Part of element-hq/element-web#9716
This tweaks the tooltip to match the color, spacing, etc. seen in the designs. Part of element-hq/element-web#9753 Part of element-hq/element-web#9716
We'd like to have a rounded point on the chevron for an extra level of polish. This implements that look for browsers that support `clip-path`. Part of element-hq/element-web#9716
6 tasks
turt2live
approved these changes
Jun 21, 2019
|
I feel like this one would fit well for the |
|
I'll go ahead and merge this, but I am planning to rework the API surface to improve interactivity and make it feel more like a normal React component, so you may want to check with me first if you really want to use in the next few days to avoid conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adds the basic look and feel of a new interactive tooltip to used for reactions and editing. There's currently no usage code in this PR, but that will be added shortly as part of further work in element-hq/element-web#9753.
Part of element-hq/element-web#9716
Part of element-hq/element-web#9753