This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
double-check user verification #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
approved these changes
Jan 31, 2020
|
Maybe we should also observe changes though and update it as the verification changes? |
|
so should I land this? |
|
I'm worried that if the verification check doesn't immediately return true after receiving the .done event, we'd never show "You've verified X" in the timeline, as we don't listen for verification status updates to rerender here... |
bwindels
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: element-hq/element-web#11968
I checked the room view panels and i don't think I broke them, but since this is some belt-and-braces code I'm not sure how to properly exercise it?