Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Transition BaseAvatar to hooks #4101

Merged
merged 5 commits into from
May 23, 2020
Merged

Transition BaseAvatar to hooks #4101

merged 5 commits into from
May 23, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 21, 2020

No description provided.

Signed-off-by: Michael Telatynski <[email protected]>
…/matrix-react-sdk into t3chguy/leaks

� Conflicts:
�	src/components/views/avatars/BaseAvatar.js
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review May 14, 2020 23:40
@t3chguy t3chguy requested a review from a team May 14, 2020 23:40
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks probably fine. I'm personally not sold on the idea of us using hooks though, as this is increasingly more complicated and less understandable than a class.

…/matrix-react-sdk into t3chguy/leaks

� Conflicts:
�	src/components/views/avatars/BaseAvatar.js
�	test/components/views/messages/TextualBody-test.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants