Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use a local wrapper for Jitsi calls #4234

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Use a local wrapper for Jitsi calls #4234

merged 5 commits into from
Mar 19, 2020

Conversation

turt2live
Copy link
Member

Requires element-hq/element-web#12780

See required PR for more information.

@turt2live turt2live marked this pull request as ready for review March 18, 2020 21:59
@turt2live turt2live requested a review from a team March 18, 2020 21:59
@jryans jryans requested review from jryans and removed request for a team March 19, 2020 15:30
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! 😁

docs/jitsi.md Outdated Show resolved Hide resolved
docs/jitsi.md Outdated Show resolved Hide resolved
src/utils/WidgetUtils.js Outdated Show resolved Hide resolved

const payload = <WidgetRequest>event.data;
if (payload.api === WidgetApiType.ToWidget && payload.action) {
console.log(`[WidgetAPI] Got request: ${JSON.stringify(payload)}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these logs safe to keep in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're already made by existing managers and Riot.

@turt2live turt2live merged commit 20d0e8a into develop Mar 19, 2020
@turt2live turt2live deleted the travis/wrapped-jitsi branch March 19, 2020 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants