This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-web#14986
Requires element-hq/element-desktop#135
Fixes element-hq/element-web#10360
This is probably reviewable commit-by-commit, though it might be best to re-read the proposal and look at the code side-by-side.
A while ago we came up with a proposal for how to handle feature flags going forward, having gone through a gauntlet of trying to turn a feature on by default. The proposal described there is what this PR implements.
The theory is that by ensuring the labs section is always readily available we solve several problems we've had with the system:
feature_name: labs
in a billion places.