This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Small delight tweaks to improve rough corners in the app #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
force-pushed
the
t3chguy/fix/muggle-hustle
branch
from
b8c91fd
to
a2958f8
Compare
t3chguy
changed the title
niquewoodhouse
approved these changes
Nov 11, 2020
dbkr
reviewed
Nov 11, 2020
| // the email anyways, and so we don't cause things to jump around. In | ||
| // theory, the user would see the user pop up and think "ah yes, that | ||
| // person!" | ||
| const profile = await MatrixClientPeg.get().getProfileInfo(lookup.mxid); |
There was a problem hiding this comment.
You may want to discard results that arrive out of order - as-you-type searching can be a bit subtle to get right: there should be code to crib from elsewhere (we should probably make it a utility class or something).
There was a problem hiding this comment.
dbkr
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9251
Fixes element-hq/element-web#14870
Fixes element-hq/element-web#12641
Fix left panel layout being wrong when filtering with 0 rooms
Fix room list join rooms prompt not showing up due to missing updates
Pass filter text when clicking explore/dm prompt
Iterate the filtering prompt
Update Room List filter copy
Tweak registration based on user feedback
