Improved forwarding UI #5999
Improved forwarding UI #5999
Conversation
Replaces the old forwarding UI with a dialog based on designs from element-hq/element-web#14690. Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
This has been replaced by ForwardDialog. Signed-off-by: Robin Townsend <[email protected]>
robintown
force-pushed
the
improved-forwarding-ui
branch
from
7580c38
to
7fa8176
Compare
|
Note that since support for verifiable forwarded messages is blocked on spec, this PR does not attempt to make any changes to how forwarded messages appear. |
|
A few design nitpicks:
Otherwise, looks awesome! 🎉 |
Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
Previously ForwardDialog was not giving its EventTile message preview the information it needed to render a ReplyThread. This was a bit tricky to fix since we were pulling a fake event out of thin air, so this ensures it doesn't regress. Signed-off-by: Robin Townsend <[email protected]>
It makes things shorter and more readable! Signed-off-by: Robin Townsend <[email protected]>
…and add a tooltip to explain why they can't accept forwarded messages. It was chosen to disable the buttons rather than hide the entries from the list, since hiding them without explanation could cause confusion. Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
|
bigger String cut the Btn Nice PR btw 👍🏻 I like it |
…to give more space between it and the buttons. Signed-off-by: Robin Townsend <[email protected]>
…so that you can jump to a room easily once you've forwarded a message there. Signed-off-by: Robin Townsend <[email protected]>
|
Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
|
Could you sort the list by recent chat activity ? I forward often media content and have to search every user who wrote recently :( THX anyway |
|
@DoM1niC That's already the intended behavior, is it behaving differently for you? |
|
Oh, I assume you're referring to the fact that direct messages are at the end of the list in a separate section. Now that I look at it again, the original design doesn't seem like it kept them separate, so I'll update this to match. |
|
Thanks @t3chguy, based on that info, I don't think making the header change of adding an info tooltip is worth it. |
|
@niquewoodhouse presumably that means you agree that forwarding should strip any reply-to metadata then to prevent that guaranteed permissions error? |
There was a problem hiding this comment.
Thank you so much @robintown, this is such a substantially better and more understandable experience. Really looking forward to testing once shipped, getting more feedback, and iterating if/when needed.
I'm not sure I do agree to be honest, but it might be because I lack some specific knowledge at this time. I'd like to separate things out anyway, this PR is about improving the forwarding UI, I think it does a great job of that. The actual thing being forwarded/the logic defining it is maybe separate - I don't want to hold this up to work that out. Presumably, this PR hasn't touched that pre-existing logic? That might come up organically from this being shipped and further issues coming up. |
|
Sure it is separate but given we're polishing Forwarding, and forwarding a message (which is a reply) to another room will ALWAYS yield that error because replies can only reply to within that same room and a forward is a copy-paste of the event JSON. |
|
It feels a bit strange that you can forward to the same room
|
I actually find that quite useful, for example if you're trying to dig up an old message for someone |
Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
...to dynamically watch for layout changes. Signed-off-by: Robin Townsend <[email protected]>
This also allows us to filter by room aliases. Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
|
last changes on develop have a lot of conflicts :( Update: recent commits fixed this THX @robintown |
As TypeScript points out, you can only set an id on HTML elements, not arbitrary components. Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
It was a bullet point, since EventTiles now get created as li by default :P Signed-off-by: Robin Townsend <[email protected]>
Signed-off-by: Robin Townsend <[email protected]>
since trying to interact with them is pointless. Signed-off-by: Robin Townsend <[email protected]>
It seems more intuitive to quote or even better reply to in that case? I don't really disagree that Element could offer this functionality, as long as it doesn't convolute the visible rooms/ordering I guess, I'm not sure what the status quo is. Great work, I have been looking "forward" to this :) |
|
@HarHarLinks, for implement right forwarding we need to accept the MSC2730: Verifiable forwarded events, as I understand. |
This replaces the old forwarding UI with a dialog based on designs from element-hq/element-web#14690.
Closes element-hq/element-web#5641.
Closes element-hq/element-web#7230.
Closes element-hq/element-web#10165.
Closes element-hq/element-web#14690.
Closes element-hq/element-web#17109.