Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Destroy playback instance on voice message unmount #6101

Merged
merged 2 commits into from
May 26, 2021

Conversation

jaiwanth-v
Copy link
Contributor

@jaiwanth-v jaiwanth-v commented May 26, 2021

This will stop playing audio when rooms are switched. Reference: element-hq/element-web#17439

Signed-off-by: Jaiwanth [email protected]

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, it also solves a possible listener leak which could bind references and leak memory

@t3chguy t3chguy merged commit 84bdd61 into matrix-org:develop May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants