Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix IRC layout regressions #6193

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jun 15, 2021

@SimonBrandner SimonBrandner changed the title Also override mx_SenderProfile_mxid Fix mxid overlap on IRC layout Jun 15, 2021
@SimonBrandner SimonBrandner marked this pull request as draft June 15, 2021 15:54
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner changed the title Fix mxid overlap on IRC layout Fix IRC layout regressions Jun 16, 2021
@SimonBrandner
Copy link
Contributor Author

SimonBrandner commented Jun 16, 2021

Peek 2021-06-16 17-31

This is the current situation which isn't exactly ideal... I am afraid that making this work, the way it did, without reversing some changes might not be possible

@SimonBrandner
Copy link
Contributor Author

Yeah, I think I've run out of ideas... I think this is better than the current broken state, so I am making this ready for review

@SimonBrandner SimonBrandner marked this pull request as ready for review June 16, 2021 15:49
@t3chguy
Copy link
Member

t3chguy commented Jun 17, 2021

Hmm IRC mode seems very jumpy for me

image

to the point I can't even target the resizer

Though that's with & without this PR but not in current app release.

@t3chguy
Copy link
Member

t3chguy commented Jun 17, 2021

Hmm so even though this is experimental I don't think this solution is usable. It feels like the wrapping component encompassing both the name and disambiguation needs to remain and then the disambiguation just needs to be a span within that with alternative styling, that way it'll go back to like it was before being fit into the layout as a single element

@SimonBrandner
Copy link
Contributor Author

Hmm IRC mode seems very jumpy for me

image

to the point I can't even target the resizer

Though that's with & without this PR but not in current app release.

Hmm, I haven't tested with timestamps hidden... That should probably be fixable, though I don't think we can get something better than what I've posted

@SimonBrandner
Copy link
Contributor Author

I've pushed changes that should fix the timestamp issues. This is far from ideal, but I believe it should work reasonably well enough before we decide what to actually do next

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to at least fix the core regression, so let's merge this, and we can improved from there as needed. Thanks for working on this!

@jryans jryans merged commit 52b578f into matrix-org:develop Jun 28, 2021
@SimonBrandner SimonBrandner deleted the fix/irc-layout-mxid/17648 branch June 28, 2021 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants