-
-
Notifications
You must be signed in to change notification settings - Fork 833
Fix IRC layout regressions #6193
Fix IRC layout regressions #6193
Conversation
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Yeah, I think I've run out of ideas... I think this is better than the current broken state, so I am making this ready for review |
Hmm so even though this is experimental I don't think this solution is usable. It feels like the wrapping component encompassing both the name and disambiguation needs to remain and then the disambiguation just needs to be a span within that with alternative styling, that way it'll go back to like it was before being fit into the layout as a single element |
Hmm, I haven't tested with timestamps hidden... That should probably be fixable, though I don't think we can get something better than what I've posted |
Signed-off-by: Šimon Brandner <[email protected]>
I've pushed changes that should fix the timestamp issues. This is far from ideal, but I believe it should work reasonably well enough before we decide what to actually do next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to at least fix the core regression, so let's merge this, and we can improved from there as needed. Thanks for working on this!
Fixes element-hq/element-web#17648
Fixes element-hq/element-web#17778