Convert widget OIDC exchange dialog to TS (fixing it) #6742

turt2live · 2021-09-04T04:32:18Z

The super call was the primary issue, but a log line in the onPermissionSelection was also using the wrong property. Both issues have been fixed as part of the TS conversion in order to make the thing compile, conveniently fixing the bugs.

Notes: Fix widgets not remembering identity verification when asked to.

Here's what your changelog entry will look like:

🐛 Bug Fixes

Fix widgets not remembering identity verification when asked to. (#6742). Fixes Prompted to share identity with jitsi widget every time I open it element-hq/element-web#15631.

Preview: https://6136ed6256506bfb78d77591--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Fixes element-hq/element-web#15631 The `super` call was the primary issue, but a log line in the `onPermissionSelection` was also using the wrong property. Both issues have been fixed as part of the TS conversion in order to make the thing compile, conveniently fixing the bugs.

src/components/views/dialogs/WidgetOpenIDPermissionsDialog.tsx

Changes in [1.9.0](https://github.com/vector-im/element-desktop/releases/tag/v1.9.0) (2021-09-27) ================================================================================================= ## ✨ Features * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\#19037](element-hq/element-web#19037)). Fixes #18481 and undefined/element-web#18481. * Say Joining space instead of Joining room where we know its a space ([\#6818](matrix-org/matrix-react-sdk#6818)). Fixes #19064 and #19064. * Add warning that some spaces may not be relinked to the newly upgraded room ([\#6805](matrix-org/matrix-react-sdk#6805)). Fixes #18858 and #18858. * Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\#6594](matrix-org/matrix-react-sdk#6594)). Fixes #18088, #18524 #18088 and #18088. * Show "Message" in the user info panel instead of "Start chat" ([\#6319](matrix-org/matrix-react-sdk#6319)). Fixes #17877 and #17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\#6804](matrix-org/matrix-react-sdk#6804)). * Replace plain text emoji at the end of a line ([\#6784](matrix-org/matrix-react-sdk#6784)). Fixes #18833 and #18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Simplify Space Panel layout and fix some edge cases ([\#6800](matrix-org/matrix-react-sdk#6800)). Fixes #18694 and #18694. * Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes #18891 and #18891. * Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\#6790](matrix-org/matrix-react-sdk#6790)). Fixes #19007 and #19007. * Fix automatic field population in space create menu not validating ([\#6792](matrix-org/matrix-react-sdk#6792)). Fixes #19005 and #19005. * Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes #12876 and #12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods). * Adapt and re-use the RolesRoomSettingsTab for Spaces ([\#6779](matrix-org/matrix-react-sdk#6779)). Fixes #18908 #18909 and #18908. * Deduplicate join rule management between rooms and spaces ([\#6724](matrix-org/matrix-react-sdk#6724)). Fixes #18798 and #18798. * Add config option to turn on in-room event sending timing metrics ([\#6766](matrix-org/matrix-react-sdk#6766)). * Improve the upgrade for restricted user experience ([\#6764](matrix-org/matrix-react-sdk#6764)). Fixes #18677 and #18677. * Improve tooltips on space quick actions and explore button ([\#6760](matrix-org/matrix-react-sdk#6760)). Fixes #18528 and #18528. * Make space members and user info behave more expectedly ([\#6765](matrix-org/matrix-react-sdk#6765)). Fixes #17018 and #17018. * hide no-op m.room.encryption events and better word param changes ([\#6747](matrix-org/matrix-react-sdk#6747)). Fixes #18597 and #18597. * Respect m.space.parent relations if they hold valid permissions ([\#6746](matrix-org/matrix-react-sdk#6746)). Fixes #10935 and #10935. * Space panel accessibility improvements ([\#6744](matrix-org/matrix-react-sdk#6744)). Fixes #18892 and #18892. ## 🐛 Bug Fixes * Fix spacing for message composer buttons ([\#6854](matrix-org/matrix-react-sdk#6854)). * Fix accessing field on oobData which may be undefined ([\#6830](matrix-org/matrix-react-sdk#6830)). Fixes #19085 and #19085. * Fix reactions aria-label not being a string and thus being read as [Object object] ([\#6828](matrix-org/matrix-react-sdk#6828)). * Fix missing null guard in space hierarchy pagination ([\#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299. * Fix checks to show prompt to start new chats ([\#6812](matrix-org/matrix-react-sdk#6812)). * Fix room list scroll jumps ([\#6777](matrix-org/matrix-react-sdk#6777)). Fixes #17460 #18440 and #17460. Contributed by [robintown](https://github.com/robintown). * Fix various message bubble alignment issues ([\#6785](matrix-org/matrix-react-sdk#6785)). Fixes #18293, #18294 #18305 and #18293. Contributed by [robintown](https://github.com/robintown). * Make message bubble font size consistent ([\#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown). * Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes #19025 and #19025. * Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes #19023 and #19023. * Stop spinner on space preview if the join fails ([\#6803](matrix-org/matrix-react-sdk#6803)). Fixes #19034 and #19034. * Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes #19012 and #19012. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\#6794](matrix-org/matrix-react-sdk#6794)). Fixes #18997 and #18997. Contributed by [Palid](https://github.com/Palid). * Fix broken edge case with public space creation with no alias ([\#6791](matrix-org/matrix-react-sdk#6791)). Fixes #19003 and #19003. * Redirect from /#/welcome to /#/home if already logged in ([\#6786](matrix-org/matrix-react-sdk#6786)). Fixes #18990 and #18990. Contributed by [aaronraimist](https://github.com/aaronraimist). * Fix build issues from two conflicting PRs landing without merge conflict ([\#6780](matrix-org/matrix-react-sdk#6780)). * Render guest settings only in public rooms/spaces ([\#6693](matrix-org/matrix-react-sdk#6693)). Fixes #18776 and #18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix message bubble corners being wrong in the presence of hidden events ([\#6776](matrix-org/matrix-react-sdk#6776)). Fixes #18124 and #18124. Contributed by [robintown](https://github.com/robintown). * Debounce read marker update on scroll ([\#6771](matrix-org/matrix-react-sdk#6771)). Fixes #18961 and #18961. * Use cursor:pointer on space panel buttons ([\#6770](matrix-org/matrix-react-sdk#6770)). Fixes #18951 and #18951. * Fix regressed tab view buttons in space update toast ([\#6761](matrix-org/matrix-react-sdk#6761)). Fixes #18781 and #18781. Changes in [1.8.6-rc.2](https://github.com/vector-im/element-desktop/releases/tag/v1.8.6-rc.2) (2021-09-22) =========================================================================================================== ## 🐛 Bug Fixes * Fix spacing for message composer buttons ([\#6854](matrix-org/matrix-react-sdk#6854)). Changes in [1.8.6-rc.1](https://github.com/vector-im/element-desktop/releases/tag/v1.8.6-rc.1) (2021-09-21) =========================================================================================================== ## ✨ Features * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\#19037](element-hq/element-web#19037)). Fixes #18481 and undefined/element-web#18481. * Say Joining space instead of Joining room where we know its a space ([\#6818](matrix-org/matrix-react-sdk#6818)). Fixes #19064 and #19064. * Add warning that some spaces may not be relinked to the newly upgraded room ([\#6805](matrix-org/matrix-react-sdk#6805)). Fixes #18858 and #18858. * Delabs Spaces, iterate some copy and move communities/space toggle to preferences ([\#6594](matrix-org/matrix-react-sdk#6594)). Fixes #18088, #18524 #18088 and #18088. * Show "Message" in the user info panel instead of "Start chat" ([\#6319](matrix-org/matrix-react-sdk#6319)). Fixes #17877 and #17877. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix space keyboard shortcuts conflicting with native zoom shortcuts ([\#6804](matrix-org/matrix-react-sdk#6804)). * Replace plain text emoji at the end of a line ([\#6784](matrix-org/matrix-react-sdk#6784)). Fixes #18833 and #18833. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Simplify Space Panel layout and fix some edge cases ([\#6800](matrix-org/matrix-react-sdk#6800)). Fixes #18694 and #18694. * Show unsent message warning on Space Panel buttons ([\#6778](matrix-org/matrix-react-sdk#6778)). Fixes #18891 and #18891. * Hide mute/unmute button in UserInfo for Spaces as it makes no sense ([\#6790](matrix-org/matrix-react-sdk#6790)). Fixes #19007 and #19007. * Fix automatic field population in space create menu not validating ([\#6792](matrix-org/matrix-react-sdk#6792)). Fixes #19005 and #19005. * Optimize input label transition on focus ([\#6783](matrix-org/matrix-react-sdk#6783)). Fixes #12876 and #12876. Contributed by [MadLittleMods](https://github.com/MadLittleMods). * Adapt and re-use the RolesRoomSettingsTab for Spaces ([\#6779](matrix-org/matrix-react-sdk#6779)). Fixes #18908 #18909 and #18908. * Deduplicate join rule management between rooms and spaces ([\#6724](matrix-org/matrix-react-sdk#6724)). Fixes #18798 and #18798. * Add config option to turn on in-room event sending timing metrics ([\#6766](matrix-org/matrix-react-sdk#6766)). * Improve the upgrade for restricted user experience ([\#6764](matrix-org/matrix-react-sdk#6764)). Fixes #18677 and #18677. * Improve tooltips on space quick actions and explore button ([\#6760](matrix-org/matrix-react-sdk#6760)). Fixes #18528 and #18528. * Make space members and user info behave more expectedly ([\#6765](matrix-org/matrix-react-sdk#6765)). Fixes #17018 and #17018. * hide no-op m.room.encryption events and better word param changes ([\#6747](matrix-org/matrix-react-sdk#6747)). Fixes #18597 and #18597. * Respect m.space.parent relations if they hold valid permissions ([\#6746](matrix-org/matrix-react-sdk#6746)). Fixes #10935 and #10935. * Space panel accessibility improvements ([\#6744](matrix-org/matrix-react-sdk#6744)). Fixes #18892 and #18892. ## 🐛 Bug Fixes * Revert Firefox composer deletion hacks ([\#6844](matrix-org/matrix-react-sdk#6844)). Fixes #19103 and #19103. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix accessing field on oobData which may be undefined ([\#6830](matrix-org/matrix-react-sdk#6830)). Fixes #19085 and #19085. * Fix pill deletion on Firefox 78 ([\#6832](matrix-org/matrix-react-sdk#6832)). Fixes #19077 and #19077. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix reactions aria-label not being a string and thus being read as [Object object] ([\#6828](matrix-org/matrix-react-sdk#6828)). * Fix missing null guard in space hierarchy pagination ([\#6821](matrix-org/matrix-react-sdk#6821)). Fixes matrix-org/element-web-rageshakes#6299 and matrix-org/element-web-rageshakes#6299. * Fix checks to show prompt to start new chats ([\#6812](matrix-org/matrix-react-sdk#6812)). * Fix room list scroll jumps ([\#6777](matrix-org/matrix-react-sdk#6777)). Fixes #17460 #18440 and #17460. Contributed by [robintown](https://github.com/robintown). * Fix various message bubble alignment issues ([\#6785](matrix-org/matrix-react-sdk#6785)). Fixes #18293, #18294 #18305 and #18293. Contributed by [robintown](https://github.com/robintown). * Make message bubble font size consistent ([\#6795](matrix-org/matrix-react-sdk#6795)). Contributed by [robintown](https://github.com/robintown). * Fix edge cases around joining new room which does not belong to active space ([\#6797](matrix-org/matrix-react-sdk#6797)). Fixes #19025 and #19025. * Fix edge case space issues around creation and initial view ([\#6798](matrix-org/matrix-react-sdk#6798)). Fixes #19023 and #19023. * Stop spinner on space preview if the join fails ([\#6803](matrix-org/matrix-react-sdk#6803)). Fixes #19034 and #19034. * Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6793](matrix-org/matrix-react-sdk#6793)). Fixes #19012 and #19012. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\#6794](matrix-org/matrix-react-sdk#6794)). Fixes #18997 and #18997. Contributed by [Palid](https://github.com/Palid). * Fix broken edge case with public space creation with no alias ([\#6791](matrix-org/matrix-react-sdk#6791)). Fixes #19003 and #19003. * Redirect from /#/welcome to /#/home if already logged in ([\#6786](matrix-org/matrix-react-sdk#6786)). Fixes #18990 and #18990. Contributed by [aaronraimist](https://github.com/aaronraimist). * Fix build issues from two conflicting PRs landing without merge conflict ([\#6780](matrix-org/matrix-react-sdk#6780)). * Render guest settings only in public rooms/spaces ([\#6693](matrix-org/matrix-react-sdk#6693)). Fixes #18776 and #18776. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix message bubble corners being wrong in the presence of hidden events ([\#6776](matrix-org/matrix-react-sdk#6776)). Fixes #18124 and #18124. Contributed by [robintown](https://github.com/robintown). * Debounce read marker update on scroll ([\#6771](matrix-org/matrix-react-sdk#6771)). Fixes #18961 and #18961. * Use cursor:pointer on space panel buttons ([\#6770](matrix-org/matrix-react-sdk#6770)). Fixes #18951 and #18951. * Fix regressed tab view buttons in space update toast ([\#6761](matrix-org/matrix-react-sdk#6761)). Fixes #18781 and #18781. Changes in [1.8.5](https://github.com/vector-im/element-desktop/releases/tag/v1.8.5) (2021-09-14) ================================================================================================= ## ✨ Features * Add bubble highlight styling ([\#6582](matrix-org/matrix-react-sdk#6582)). Fixes #18295 and #18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Create narrow mode for Composer ([\#6682](matrix-org/matrix-react-sdk#6682)). Fixes #18533 and #18533. * Prefer matrix.to alias links over room id in spaces & share ([\#6745](matrix-org/matrix-react-sdk#6745)). Fixes #18796 and #18796. * Stop automatic playback of voice messages if a non-voice message is encountered ([\#6728](matrix-org/matrix-react-sdk#6728)). Fixes #18850 and #18850. * Show call length during a call ([\#6700](matrix-org/matrix-react-sdk#6700)). Fixes #18566 and #18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Serialize and retry mass-leave when leaving space ([\#6737](matrix-org/matrix-react-sdk#6737)). Fixes #18789 and #18789. * Improve form handling in and around space creation ([\#6739](matrix-org/matrix-react-sdk#6739)). Fixes #18775 and #18775. * Split autoplay GIFs and videos into different settings ([\#6726](matrix-org/matrix-react-sdk#6726)). Fixes #5771 and #5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add autoplay for voice messages ([\#6710](matrix-org/matrix-react-sdk#6710)). Fixes #18804, #18715, #18714 #17961 and #18804. * Allow to use basic html to format invite messages ([\#6703](matrix-org/matrix-react-sdk#6703)). Fixes #15738 and #15738. Contributed by [skolmer](https://github.com/skolmer). * Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\#6684](matrix-org/matrix-react-sdk#6684)). * Remove arbitrary limits from send/receive events for widgets ([\#6719](matrix-org/matrix-react-sdk#6719)). Fixes #17994 and #17994. * Reload suggested rooms if we see the state change down /sync ([\#6715](matrix-org/matrix-react-sdk#6715)). Fixes #18761 and #18761. * When creating private spaces, make the initial rooms restricted if supported ([\#6721](matrix-org/matrix-react-sdk#6721)). Fixes #18722 and #18722. * Threading exploration work ([\#6658](matrix-org/matrix-react-sdk#6658)). Fixes #18532 and #18532. * Default to `Don't leave any` when leaving a space ([\#6697](matrix-org/matrix-react-sdk#6697)). Fixes #18592 and #18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Special case redaction event sending from widgets per MSC2762 ([\#6686](matrix-org/matrix-react-sdk#6686)). Fixes #18573 and #18573. * Add active speaker indicators ([\#6639](matrix-org/matrix-react-sdk#6639)). Fixes #17627 and #17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Increase general app performance by optimizing layers ([\#6644](matrix-org/matrix-react-sdk#6644)). Fixes #18730 and #18730. Contributed by [Palid](https://github.com/Palid). ## 🐛 Bug Fixes * Fix autocomplete not having y-scroll ([\#6802](matrix-org/matrix-react-sdk#6802)). * Fix emoji picker and stickerpicker not appearing correctly when opened ([\#6801](matrix-org/matrix-react-sdk#6801)). * Debounce read marker update on scroll ([\#6774](matrix-org/matrix-react-sdk#6774)). * Fix Space creation wizard go to my first room button behaviour ([\#6748](matrix-org/matrix-react-sdk#6748)). Fixes #18764 and #18764. * Fix scroll being stuck at bottom ([\#6751](matrix-org/matrix-react-sdk#6751)). Fixes #18903 and #18903. * Fix widgets not remembering identity verification when asked to. ([\#6742](matrix-org/matrix-react-sdk#6742)). Fixes #15631 and #15631. * Add missing pluralisation i18n strings for Spaces ([\#6738](matrix-org/matrix-react-sdk#6738)). Fixes #18780 and #18780. * Make ForgotPassword UX slightly more user friendly ([\#6636](matrix-org/matrix-react-sdk#6636)). Fixes #11531 and #11531. Contributed by [Palid](https://github.com/Palid). * Don't context switch room on SpaceStore ready as it can break permalinks ([\#6730](matrix-org/matrix-react-sdk#6730)). Fixes #17974 and #17974. * Fix explore rooms button not working during space creation wizard ([\#6729](matrix-org/matrix-react-sdk#6729)). Fixes #18762 and #18762. * Fix bug where one party's media would sometimes not be shown ([\#6731](matrix-org/matrix-react-sdk#6731)). * Only make the initial space rooms suggested by default ([\#6714](matrix-org/matrix-react-sdk#6714)). Fixes #18760 and #18760. * Replace fake username in EventTilePreview with a proper loading state ([\#6702](matrix-org/matrix-react-sdk#6702)). Fixes #15897 and #15897. Contributed by [skolmer](https://github.com/skolmer). * Don't send prehistorical events to widgets during decryption at startup ([\#6695](matrix-org/matrix-react-sdk#6695)). Fixes #18060 and #18060. * When creating subspaces properly set restricted join rule ([\#6725](matrix-org/matrix-react-sdk#6725)). Fixes #18797 and #18797. * Fix the Image View not openning for some pinned messages ([\#6723](matrix-org/matrix-react-sdk#6723)). Fixes #18422 and #18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Show autocomplete sections vertically ([\#6722](matrix-org/matrix-react-sdk#6722)). Fixes #18860 and #18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix EmojiPicker filtering to lower case emojibase data strings ([\#6717](matrix-org/matrix-react-sdk#6717)). Fixes #18686 and #18686. * Clear currentRoomId when viewing home page, fixing document title ([\#6716](matrix-org/matrix-react-sdk#6716)). Fixes #18668 and #18668. * Fix membership updates to Spaces not applying in real-time ([\#6713](matrix-org/matrix-react-sdk#6713)). Fixes #18737 and #18737. * Don't show a double stacked invite modals when inviting to Spaces ([\#6698](matrix-org/matrix-react-sdk#6698)). Fixes #18745 and #18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Remove non-functional DuckDuckGo Autocomplete Provider ([\#6712](matrix-org/matrix-react-sdk#6712)). Fixes #18778 and #18778. * Filter members on `MemberList` load ([\#6708](matrix-org/matrix-react-sdk#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\#6696](matrix-org/matrix-react-sdk#6696)). Fixes #18587 and #18587. * Fix client forgetting which capabilities a widget was approved for ([\#6685](matrix-org/matrix-react-sdk#6685)). Fixes #18786 and #18786. * Fix left panel widgets not remembering collapsed state ([\#6687](matrix-org/matrix-react-sdk#6687)). Fixes #17803 and #17803. * Fix changelog link colour back to blue ([\#6692](matrix-org/matrix-react-sdk#6692)). Fixes #18726 and #18726. * Soften codeblock border color ([\#6564](matrix-org/matrix-react-sdk#6564)). Fixes #18367 and #18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Pause ringing more aggressively ([\#6691](matrix-org/matrix-react-sdk#6691)). Fixes #18588 and #18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix command autocomplete ([\#6680](matrix-org/matrix-react-sdk#6680)). Fixes #18670 and #18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Don't re-sort the room-list based on profile/status changes ([\#6595](matrix-org/matrix-react-sdk#6595)). Fixes #110 and #110. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix codeblock formatting with syntax highlighting on ([\#6681](matrix-org/matrix-react-sdk#6681)). Fixes #18739 #18365 and #18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add padding to the Add button in the notification settings ([\#6665](matrix-org/matrix-react-sdk#6665)). Fixes #18706 and #18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner).

* Add bubble highlight styling ([\element-hq#6582](matrix-org/matrix-react-sdk#6582)). Fixes element-hq#18295 and element-hq#18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Create narrow mode for Composer ([\#6682](matrix-org/matrix-react-sdk#6682)). Fixes element-hq#18533 and element-hq#18533. * Prefer matrix.to alias links over room id in spaces & share ([\element-hq#6745](matrix-org/matrix-react-sdk#6745)). Fixes element-hq#18796 and element-hq#18796. * Stop automatic playback of voice messages if a non-voice message is encountered ([\element-hq#6728](matrix-org/matrix-react-sdk#6728)). Fixes element-hq#18850 and element-hq#18850. * Show call length during a call ([\element-hq#6700](matrix-org/matrix-react-sdk#6700)). Fixes element-hq#18566 and element-hq#18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Serialize and retry mass-leave when leaving space ([\element-hq#6737](matrix-org/matrix-react-sdk#6737)). Fixes element-hq#18789 and element-hq#18789. * Improve form handling in and around space creation ([\#6739](matrix-org/matrix-react-sdk#6739)). Fixes element-hq#18775 and element-hq#18775. * Split autoplay GIFs and videos into different settings ([\element-hq#6726](matrix-org/matrix-react-sdk#6726)). Fixes element-hq#5771 and element-hq#5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add autoplay for voice messages ([\element-hq#6710](matrix-org/matrix-react-sdk#6710)). Fixes element-hq#18804, element-hq#18715, element-hq#18714 element-hq#17961 and element-hq#18804. * Allow to use basic html to format invite messages ([\#6703](matrix-org/matrix-react-sdk#6703)). Fixes element-hq#15738 and element-hq#15738. Contributed by [skolmer](https://github.com/skolmer). * Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\element-hq#6684](matrix-org/matrix-react-sdk#6684)). * Remove arbitrary limits from send/receive events for widgets ([\element-hq#6719](matrix-org/matrix-react-sdk#6719)). Fixes element-hq#17994 and element-hq#17994. * Reload suggested rooms if we see the state change down /sync ([\element-hq#6715](matrix-org/matrix-react-sdk#6715)). Fixes element-hq#18761 and element-hq#18761. * When creating private spaces, make the initial rooms restricted if supported ([\element-hq#6721](matrix-org/matrix-react-sdk#6721)). Fixes element-hq#18722 and element-hq#18722. * Threading exploration work ([\element-hq#6658](matrix-org/matrix-react-sdk#6658)). Fixes element-hq#18532 and element-hq#18532. * Default to `Don't leave any` when leaving a space ([\element-hq#6697](matrix-org/matrix-react-sdk#6697)). Fixes element-hq#18592 and element-hq#18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Special case redaction event sending from widgets per MSC2762 ([\element-hq#6686](matrix-org/matrix-react-sdk#6686)). Fixes element-hq#18573 and element-hq#18573. * Add active speaker indicators ([\element-hq#6639](matrix-org/matrix-react-sdk#6639)). Fixes element-hq#17627 and element-hq#17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Increase general app performance by optimizing layers ([\element-hq#6644](matrix-org/matrix-react-sdk#6644)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\element-hq#6802](matrix-org/matrix-react-sdk#6802)). * Fix emoji picker and stickerpicker not appearing correctly when opened ([\element-hq#6801](matrix-org/matrix-react-sdk#6801)). * Debounce read marker update on scroll ([\element-hq#6774](matrix-org/matrix-react-sdk#6774)). * Fix Space creation wizard go to my first room button behaviour ([\element-hq#6748](matrix-org/matrix-react-sdk#6748)). Fixes element-hq#18764 and element-hq#18764. * Fix scroll being stuck at bottom ([\element-hq#6751](matrix-org/matrix-react-sdk#6751)). Fixes element-hq#18903 and element-hq#18903. * Fix widgets not remembering identity verification when asked to. ([\element-hq#6742](matrix-org/matrix-react-sdk#6742)). Fixes element-hq#15631 and element-hq#15631. * Add missing pluralisation i18n strings for Spaces ([\element-hq#6738](matrix-org/matrix-react-sdk#6738)). Fixes element-hq#18780 and element-hq#18780. * Make ForgotPassword UX slightly more user friendly ([\#6636](matrix-org/matrix-react-sdk#6636)). Fixes element-hq#11531 and element-hq#11531. Contributed by [Palid](https://github.com/Palid). * Don't context switch room on SpaceStore ready as it can break permalinks ([\element-hq#6730](matrix-org/matrix-react-sdk#6730)). Fixes element-hq#17974 and element-hq#17974. * Fix explore rooms button not working during space creation wizard ([\element-hq#6729](matrix-org/matrix-react-sdk#6729)). Fixes element-hq#18762 and element-hq#18762. * Fix bug where one party's media would sometimes not be shown ([\element-hq#6731](matrix-org/matrix-react-sdk#6731)). * Only make the initial space rooms suggested by default ([\element-hq#6714](matrix-org/matrix-react-sdk#6714)). Fixes element-hq#18760 and element-hq#18760. * Replace fake username in EventTilePreview with a proper loading state ([\element-hq#6702](matrix-org/matrix-react-sdk#6702)). Fixes element-hq#15897 and element-hq#15897. Contributed by [skolmer](https://github.com/skolmer). * Don't send prehistorical events to widgets during decryption at startup ([\element-hq#6695](matrix-org/matrix-react-sdk#6695)). Fixes element-hq#18060 and element-hq#18060. * When creating subspaces properly set restricted join rule ([\element-hq#6725](matrix-org/matrix-react-sdk#6725)). Fixes element-hq#18797 and element-hq#18797. * Fix the Image View not openning for some pinned messages ([\element-hq#6723](matrix-org/matrix-react-sdk#6723)). Fixes element-hq#18422 and element-hq#18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Show autocomplete sections vertically ([\element-hq#6722](matrix-org/matrix-react-sdk#6722)). Fixes element-hq#18860 and element-hq#18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix EmojiPicker filtering to lower case emojibase data strings ([\element-hq#6717](matrix-org/matrix-react-sdk#6717)). Fixes element-hq#18686 and element-hq#18686. * Clear currentRoomId when viewing home page, fixing document title ([\element-hq#6716](matrix-org/matrix-react-sdk#6716)). Fixes element-hq#18668 and element-hq#18668. * Fix membership updates to Spaces not applying in real-time ([\element-hq#6713](matrix-org/matrix-react-sdk#6713)). Fixes element-hq#18737 and element-hq#18737. * Don't show a double stacked invite modals when inviting to Spaces ([\element-hq#6698](matrix-org/matrix-react-sdk#6698)). Fixes element-hq#18745 and element-hq#18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Remove non-functional DuckDuckGo Autocomplete Provider ([\element-hq#6712](matrix-org/matrix-react-sdk#6712)). Fixes element-hq#18778 and element-hq#18778. * Filter members on `MemberList` load ([\element-hq#6708](matrix-org/matrix-react-sdk#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\element-hq#6696](matrix-org/matrix-react-sdk#6696)). Fixes element-hq#18587 and element-hq#18587. * Fix client forgetting which capabilities a widget was approved for ([\element-hq#6685](matrix-org/matrix-react-sdk#6685)). Fixes element-hq#18786 and element-hq#18786. * Fix left panel widgets not remembering collapsed state ([\element-hq#6687](matrix-org/matrix-react-sdk#6687)). Fixes element-hq#17803 and element-hq#17803. * Fix changelog link colour back to blue ([\element-hq#6692](matrix-org/matrix-react-sdk#6692)). Fixes element-hq#18726 and element-hq#18726. * Soften codeblock border color ([\element-hq#6564](matrix-org/matrix-react-sdk#6564)). Fixes element-hq#18367 and element-hq#18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Pause ringing more aggressively ([\element-hq#6691](matrix-org/matrix-react-sdk#6691)). Fixes element-hq#18588 and element-hq#18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix command autocomplete ([\element-hq#6680](matrix-org/matrix-react-sdk#6680)). Fixes element-hq#18670 and element-hq#18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Don't re-sort the room-list based on profile/status changes ([\element-hq#6595](matrix-org/matrix-react-sdk#6595)). Fixes #110 and #110. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix codeblock formatting with syntax highlighting on ([\element-hq#6681](matrix-org/matrix-react-sdk#6681)). Fixes element-hq#18739 element-hq#18365 and element-hq#18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add padding to the Add button in the notification settings ([\element-hq#6665](matrix-org/matrix-react-sdk#6665)). Fixes element-hq#18706 and element-hq#18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner). Change-Id: I8844e7c1f52e9e42ae9a0d6b1cd0ea6ee5fcf9a6

* Add bubble highlight styling ([\matrix-org#6582](matrix-org#6582)). Fixes element-hq/element-web#18295 and element-hq/element-web#18295. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * [Release] Add config option to turn on in-room event sending timing metrics ([\matrix-org#6773](matrix-org#6773)). * Create narrow mode for Composer ([\matrix-org#6682](matrix-org#6682)). Fixes element-hq/element-web#18533 and element-hq/element-web#18533. * Prefer matrix.to alias links over room id in spaces & share ([\matrix-org#6745](matrix-org#6745)). Fixes element-hq/element-web#18796 and element-hq/element-web#18796. * Stop automatic playback of voice messages if a non-voice message is encountered ([\matrix-org#6728](matrix-org#6728)). Fixes element-hq/element-web#18850 and element-hq/element-web#18850. * Show call length during a call ([\matrix-org#6700](matrix-org#6700)). Fixes element-hq/element-web#18566 and element-hq/element-web#18566. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Serialize and retry mass-leave when leaving space ([\matrix-org#6737](matrix-org#6737)). Fixes element-hq/element-web#18789 and element-hq/element-web#18789. * Improve form handling in and around space creation ([\matrix-org#6739](matrix-org#6739)). Fixes element-hq/element-web#18775 and element-hq/element-web#18775. * Split autoplay GIFs and videos into different settings ([\matrix-org#6726](matrix-org#6726)). Fixes element-hq/element-web#5771 and element-hq/element-web#5771. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add autoplay for voice messages ([\matrix-org#6710](matrix-org#6710)). Fixes element-hq/element-web#18804, element-hq/element-web#18715, element-hq/element-web#18714 element-hq/element-web#17961 and element-hq/element-web#18804. * Allow to use basic html to format invite messages ([\matrix-org#6703](matrix-org#6703)). Fixes element-hq/element-web#15738 and element-hq/element-web#15738. Contributed by [skolmer](https://github.com/skolmer). * Allow widgets, when eligible, to interact with more rooms as per MSC2762 ([\matrix-org#6684](matrix-org#6684)). * Remove arbitrary limits from send/receive events for widgets ([\matrix-org#6719](matrix-org#6719)). Fixes element-hq/element-web#17994 and element-hq/element-web#17994. * Reload suggested rooms if we see the state change down /sync ([\matrix-org#6715](matrix-org#6715)). Fixes element-hq/element-web#18761 and element-hq/element-web#18761. * When creating private spaces, make the initial rooms restricted if supported ([\matrix-org#6721](matrix-org#6721)). Fixes element-hq/element-web#18722 and element-hq/element-web#18722. * Threading exploration work ([\matrix-org#6658](matrix-org#6658)). Fixes element-hq/element-web#18532 and element-hq/element-web#18532. * Default to `Don't leave any` when leaving a space ([\matrix-org#6697](matrix-org#6697)). Fixes element-hq/element-web#18592 and element-hq/element-web#18592. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Special case redaction event sending from widgets per MSC2762 ([\matrix-org#6686](matrix-org#6686)). Fixes element-hq/element-web#18573 and element-hq/element-web#18573. * Add active speaker indicators ([\matrix-org#6639](matrix-org#6639)). Fixes element-hq/element-web#17627 and element-hq/element-web#17627. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Increase general app performance by optimizing layers ([\matrix-org#6644](matrix-org#6644)). Fixes element-hq/element-web#18730 and element-hq/element-web#18730. Contributed by [Palid](https://github.com/Palid). * Fix autocomplete not having y-scroll ([\matrix-org#6802](matrix-org#6802)). * Fix emoji picker and stickerpicker not appearing correctly when opened ([\matrix-org#6801](matrix-org#6801)). * Debounce read marker update on scroll ([\matrix-org#6774](matrix-org#6774)). * Fix Space creation wizard go to my first room button behaviour ([\matrix-org#6748](matrix-org#6748)). Fixes element-hq/element-web#18764 and element-hq/element-web#18764. * Fix scroll being stuck at bottom ([\matrix-org#6751](matrix-org#6751)). Fixes element-hq/element-web#18903 and element-hq/element-web#18903. * Fix widgets not remembering identity verification when asked to. ([\matrix-org#6742](matrix-org#6742)). Fixes element-hq/element-web#15631 and element-hq/element-web#15631. * Add missing pluralisation i18n strings for Spaces ([\matrix-org#6738](matrix-org#6738)). Fixes element-hq/element-web#18780 and element-hq/element-web#18780. * Make ForgotPassword UX slightly more user friendly ([\matrix-org#6636](matrix-org#6636)). Fixes element-hq/element-web#11531 and element-hq/element-web#11531. Contributed by [Palid](https://github.com/Palid). * Don't context switch room on SpaceStore ready as it can break permalinks ([\matrix-org#6730](matrix-org#6730)). Fixes element-hq/element-web#17974 and element-hq/element-web#17974. * Fix explore rooms button not working during space creation wizard ([\matrix-org#6729](matrix-org#6729)). Fixes element-hq/element-web#18762 and element-hq/element-web#18762. * Fix bug where one party's media would sometimes not be shown ([\matrix-org#6731](matrix-org#6731)). * Only make the initial space rooms suggested by default ([\matrix-org#6714](matrix-org#6714)). Fixes element-hq/element-web#18760 and element-hq/element-web#18760. * Replace fake username in EventTilePreview with a proper loading state ([\matrix-org#6702](matrix-org#6702)). Fixes element-hq/element-web#15897 and element-hq/element-web#15897. Contributed by [skolmer](https://github.com/skolmer). * Don't send prehistorical events to widgets during decryption at startup ([\matrix-org#6695](matrix-org#6695)). Fixes element-hq/element-web#18060 and element-hq/element-web#18060. * When creating subspaces properly set restricted join rule ([\matrix-org#6725](matrix-org#6725)). Fixes element-hq/element-web#18797 and element-hq/element-web#18797. * Fix the Image View not openning for some pinned messages ([\matrix-org#6723](matrix-org#6723)). Fixes element-hq/element-web#18422 and element-hq/element-web#18422. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Show autocomplete sections vertically ([\matrix-org#6722](matrix-org#6722)). Fixes element-hq/element-web#18860 and element-hq/element-web#18860. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix EmojiPicker filtering to lower case emojibase data strings ([\matrix-org#6717](matrix-org#6717)). Fixes element-hq/element-web#18686 and element-hq/element-web#18686. * Clear currentRoomId when viewing home page, fixing document title ([\matrix-org#6716](matrix-org#6716)). Fixes element-hq/element-web#18668 and element-hq/element-web#18668. * Fix membership updates to Spaces not applying in real-time ([\matrix-org#6713](matrix-org#6713)). Fixes element-hq/element-web#18737 and element-hq/element-web#18737. * Don't show a double stacked invite modals when inviting to Spaces ([\matrix-org#6698](matrix-org#6698)). Fixes element-hq/element-web#18745 and element-hq/element-web#18745. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Remove non-functional DuckDuckGo Autocomplete Provider ([\matrix-org#6712](matrix-org#6712)). Fixes element-hq/element-web#18778 and element-hq/element-web#18778. * Filter members on `MemberList` load ([\matrix-org#6708](matrix-org#6708)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix improper voice messages being produced in Firefox and sometimes other browsers. ([\matrix-org#6696](matrix-org#6696)). Fixes element-hq/element-web#18587 and element-hq/element-web#18587. * Fix client forgetting which capabilities a widget was approved for ([\matrix-org#6685](matrix-org#6685)). Fixes element-hq/element-web#18786 and element-hq/element-web#18786. * Fix left panel widgets not remembering collapsed state ([\matrix-org#6687](matrix-org#6687)). Fixes element-hq/element-web#17803 and element-hq/element-web#17803. * Fix changelog link colour back to blue ([\matrix-org#6692](matrix-org#6692)). Fixes element-hq/element-web#18726 and element-hq/element-web#18726. * Soften codeblock border color ([\matrix-org#6564](matrix-org#6564)). Fixes element-hq/element-web#18367 and element-hq/element-web#18367. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Pause ringing more aggressively ([\matrix-org#6691](matrix-org#6691)). Fixes element-hq/element-web#18588 and element-hq/element-web#18588. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix command autocomplete ([\matrix-org#6680](matrix-org#6680)). Fixes element-hq/element-web#18670 and element-hq/element-web#18670. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Don't re-sort the room-list based on profile/status changes ([\matrix-org#6595](matrix-org#6595)). Fixes vector-im/element-web#110 and vector-im/element-web#110. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix codeblock formatting with syntax highlighting on ([\matrix-org#6681](matrix-org#6681)). Fixes element-hq/element-web#18739 element-hq/element-web#18365 and element-hq/element-web#18739. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Add padding to the Add button in the notification settings ([\matrix-org#6665](matrix-org#6665)). Fixes element-hq/element-web#18706 and element-hq/element-web#18706. Contributed by [SimonBrandner](https://github.com/SimonBrandner). # Conflicts: # src/components/structures/MessagePanel.js # src/components/structures/RoomView.tsx # src/components/views/settings/tabs/user/HelpUserSettingsTab.js # src/i18n/strings/de_DE.json # src/utils/permalinks/SpecPermalinkConstructor.ts Change-Id: I526ee4e0de3ec11f735f782aa2ebd94ff23cca15

turt2live added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 4, 2021

turt2live requested a review from a team as a code owner September 4, 2021 04:32

Palid approved these changes Sep 4, 2021

View reviewed changes

src/components/views/dialogs/WidgetOpenIDPermissionsDialog.tsx Show resolved Hide resolved

Add missing type

615a432

turt2live enabled auto-merge September 7, 2021 04:37

turt2live merged commit 78617c0 into develop Sep 7, 2021

turt2live deleted the travis/fix-oidc-dialog branch September 7, 2021 04:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert widget OIDC exchange dialog to TS (fixing it) #6742

Convert widget OIDC exchange dialog to TS (fixing it) #6742

turt2live commented Sep 4, 2021 •

edited by github-actions bot

Loading

Convert widget OIDC exchange dialog to TS (fixing it) #6742

Convert widget OIDC exchange dialog to TS (fixing it) #6742

Conversation

turt2live commented Sep 4, 2021 • edited by github-actions bot Loading

🐛 Bug Fixes

turt2live commented Sep 4, 2021 •

edited by github-actions bot

Loading