Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow quote-reply in thread view element-web #6959

Merged
merged 7 commits into from
Oct 19, 2021

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Oct 15, 2021

Fixes element-hq/element-web#19206
Fixes element-hq/element-web#19161
Fixes element-hq/element-web#19205

Will conflict with #6960

  • Scope reply preview to current rendering type
  • Deleting dead ThreadPanelItem component
  • Display quote replies for TileShape.Thread

Screen Shot 2021-10-19 at 09 45 24


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://616e8cf90769b31486a58fa8--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from a team as a code owner October 15, 2021 16:29
@germain-gg germain-gg added the X-Blocked The PR cannot move forward in any capacity until an action is made label Oct 15, 2021
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine - thank you!

Can we get screenshots in the PR description so we know what this is supposed to look like in the event we break it?

@germain-gg germain-gg removed the X-Blocked The PR cannot move forward in any capacity until an action is made label Oct 19, 2021
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@germain-gg germain-gg merged commit 694ec94 into develop Oct 19, 2021
@germain-gg germain-gg deleted the gsouquet/threads-quote-replies branch October 19, 2021 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants