This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve handling of encryption key that is not available #7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Keyring is unavailable or not unlocked Element would start without being able to decrypt messages. This fix will ensure Element doesn't start unless it was able to retrieve the encryption key. Unlocking the Keyring at a later time would not result in the messages being decrypted. The app would need to be restarted to achieve this. This fixes https://github.com/vector-im/element-web/issues/17845
MadLittleMods
added
Z-Community-PR
|
Related to #8272 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to fix element-hq/element-desktop#688 and came up with the following: ReneHollander@a6caf94
This approach is less then ideal as there being no key in the Keyring (e.g the user reset the keyring) would lead to Element being stuck in an endless loading loop at startup without any indication what's going on (see [1]).
I am not too familiar with the codebase and I am wondering if a more experienced maintainer can give me a hint or two on how to implement this properly. I would have the following idea:
Alternatively maybe on the intitial loading page [1] that would persist until the key is found add a message that it's waiting on the encryption key to be available. This might be easier to implement.
[1] Screen shown while trying to get the encryption key:
Here's what your changelog entry will look like:
🐛 Bug Fixes