Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Unit tests for getEffectiveTheme #7051

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Oct 28, 2021

I realised I wrote some complex logic in #7043 without unit tests, so I am belatedly adding them.


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://617ab47fbfb87b0071877863--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 28, 2021
@andybalaam andybalaam requested a review from a team as a code owner October 28, 2021 14:29
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for tests <3

@andybalaam andybalaam merged commit d0bb6e0 into matrix-org:develop Oct 29, 2021
@andybalaam andybalaam deleted the psfd-360-unit-tests-for-geteffectivetheme branch October 29, 2021 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants