Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use & enforce snake_case naming convention on config.json settings #8062

Merged
merged 9 commits into from
Mar 18, 2022
Merged

Use & enforce snake_case naming convention on config.json settings #8062

merged 9 commits into from
Mar 18, 2022

Commits on Mar 16, 2022

  1. Document and support the established naming convention for config opts 

    This change:
* Rename `ConfigOptions` to `IConfigOptions` to match code convention/style, plus move it to a dedicated file
* Update comments and surrounding documentation
* Define every single documented option (from element-web's config.md)
* Enable a linter to enforce the convention
* Invent a translation layer for a different change to use
* No attempt to fix build errors from doing this (at this stage)
    @turt2live
    turt2live committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    0109e34 View commit details
    Browse the repository at this point in the history

  2. Add demo of lint rule in action

    @turt2live
    turt2live committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    da217d2 View commit details
    Browse the repository at this point in the history

  3. Fix all obvious instances of SdkConfig case conflicts

    @turt2live
    turt2live committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    4b320d0 View commit details
    Browse the repository at this point in the history

  4. Fix tests to use SdkConfig directly

    @turt2live
    turt2live committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    15353f0 View commit details
    Browse the repository at this point in the history

  5. Add docs to make unset() calling safer

    @turt2live
    turt2live committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    c0cf7f1 View commit details
    Browse the repository at this point in the history

  6. Appease the linter

    @turt2live
    turt2live committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    e3bf0bc View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Update documentation to match snake_case_config

    @turt2live
    turt2live committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    f6fdfaa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into travis/sssssssnake_case_config

    @turt2live
    turt2live committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    6b522cb View commit details
    Browse the repository at this point in the history

  3. Fix more instances of square brackets off SdkConfig

    @turt2live
    turt2live committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    04b77db View commit details
    Browse the repository at this point in the history