This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Extract Tag to its own component #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for element-hq/element-web#21354
t3chguy
reviewed
Apr 13, 2022
Codecov Report
@@ Coverage Diff @@
## develop #8309 +/- ##
========================================
Coverage 29.80% 29.81%
========================================
Files 874 875 +1
Lines 50017 50023 +6
Branches 12726 12729 +3
========================================
+ Hits 14908 14913 +5
- Misses 35109 35110 +1
|
t3chguy
approved these changes
Apr 13, 2022
Johennes
pushed a commit
to Johennes/matrix-react-sdk
that referenced
this pull request
Apr 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for element-hq/element-web#21354
This extracts
Tagto its own component and consolidates the implementation to match the Figma designThe screenshots below have been extracted from the "Notifications" section of the settings, and is currently the only place where those are used
💅 After
🏚 Before
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.Preview: https://pr8309--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.