Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Log errors in english #8508

Closed
wants to merge 2 commits into from
Closed

Log errors in english #8508

wants to merge 2 commits into from

Conversation

nullity00
Copy link
Contributor

@nullity00 nullity00 commented May 5, 2022

When using element.io in languages other than English, a few errors in console get logged in the native language as addressed by issue #9597

Summary of Changes done :

  • Changed all err.message to English
  • Added _t() in Modal Descriptions . eg., description: _t(errMsg)

Signed Off by : Reshma [email protected]


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Log errors in english (#8508). Contributed by @TheReshma.

@nullity00 nullity00 requested a review from a team as a code owner May 5, 2022 16:44
@kerryarchibald kerryarchibald added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 6, 2022
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make use of the newTranslatableError helper function we use elsewhere

@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 1, 2022
@nullity00 nullity00 closed this Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants